Skip to content

Commit

Permalink
don't sort builtin workspaces
Browse files Browse the repository at this point in the history
  • Loading branch information
Eism committed Feb 21, 2025
1 parent 3b88113 commit 8e99b61
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
13 changes: 6 additions & 7 deletions src/framework/workspace/internal/workspacemanager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -308,16 +308,15 @@ io::paths_t WorkspaceManager::findWorkspaceFiles() const
};

io::paths_t builtinWorkspacesPaths = configuration()->builtinWorkspacesFilePaths();

io::paths_t userWorkspacesPaths = findFiles(configuration()->userWorkspacesPath());
std::set<io::path_t> userWorkspacesFileNames;
for (const io::path_t& dirPath : userWorkspacesPaths) {
userWorkspacesFileNames.insert(io::filename(dirPath));
std::set<io::path_t> builtinWorkspacesFileNames;
for (const io::path_t& dirPath : builtinWorkspacesPaths) {
builtinWorkspacesFileNames.insert(io::filename(dirPath));
}

muse::remove_if(builtinWorkspacesPaths, [=](const io::path_t& path) -> bool {
io::paths_t userWorkspacesPaths = findFiles(configuration()->userWorkspacesPath());
muse::remove_if(userWorkspacesPaths, [=](const io::path_t& path) -> bool {
io::path_t fileName = io::filename(path);
return muse::contains(userWorkspacesFileNames, fileName);
return muse::contains(builtinWorkspacesFileNames, fileName);
});

io::paths_t result;
Expand Down
4 changes: 4 additions & 0 deletions src/framework/workspace/internal/workspaceutils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,9 @@ bool WorkspaceUtils::workspaceLessThan(const IWorkspacePtr& workspace1, const IW
return isWorkspace1Builtin;
}

if (isWorkspace1Builtin && isWorkspace2Builtin) {
return false;
}

return workspace1->name() < workspace2->name();
}

0 comments on commit 8e99b61

Please sign in to comment.