Merge pull request #24002 from RomanPudashkin/dbl_click_fix

dbl_click_fix
musescore · Aug 14, 2024 · f1a01b2 · f1a01b2
2 parents 7e19800 + 8bcec64
commit f1a01b2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/src/notation/view/notationviewinputcontroller.cpp b/src/notation/view/notationviewinputcontroller.cpp
@@ -890,6 +890,12 @@ void NotationViewInputController::handleLeftClickRelease(const QPointF& releaseP
         return;
     }
 
+    if (m_shouldStartEditOnLeftClickRelease) {
+        dispatcher()->dispatch("edit-element", ActionData::make_arg1<PointF>(m_logicalBeginPoint));
+        m_shouldStartEditOnLeftClickRelease = false;
+        return;
+    }
+
     const INotationInteraction::HitElementContext& ctx = hitElementContext();
     if (!ctx.element) {
         return;
@@ -953,16 +959,10 @@ void NotationViewInputController::mouseDoubleClickEvent(QMouseEvent* event)
         return;
     }
 
-    ActionCode actionCode;
-
     if (hitElement->isMeasure() && event->modifiers() == Qt::NoModifier) {
-        actionCode = "note-input";
+        dispatcher()->dispatch("note-input", ActionData::make_arg1<PointF>(m_logicalBeginPoint));
     } else if (hitElement->isInstrumentName()) {
-        actionCode = "edit-element";
-    }
-
-    if (!actionCode.empty()) {
-        dispatcher()->dispatch(actionCode, ActionData::make_arg1<PointF>(m_logicalBeginPoint));
+        m_shouldStartEditOnLeftClickRelease = true;
     }
 }
 

diff --git a/src/notation/view/notationviewinputcontroller.h b/src/notation/view/notationviewinputcontroller.h
@@ -198,6 +198,8 @@ class NotationViewInputController : public muse::actions::Actionable, public mus
 
     mu::engraving::EngravingItem* m_prevHitElement = nullptr;
     mu::engraving::EngravingItem* m_prevSelectedElement = nullptr;
+
+    bool m_shouldStartEditOnLeftClickRelease = false;
     bool m_shouldTogglePopupOnLeftClickRelease = false;
 };
 }