-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jack-midi support #19246
Open
lyrra
wants to merge
60
commits into
musescore:master
Choose a base branch
from
lyrra:jack
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
jack-midi support #19246
+2,155
−955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce43ca7
to
b218652
Compare
7638762
to
22128db
Compare
999e2a8
to
7a2a941
Compare
3e582e1
to
24705bc
Compare
f56bf85
to
01f03a1
Compare
Merged
932c742
to
77c9dbe
Compare
Co-authored-by: Casper Jeukendrup <[email protected]>
Co-authored-by: Casper Jeukendrup <[email protected]>
is guiapp a good place though? it seems to do high-level gui init only
3e3dc9e
to
c03609b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
For linux users, the ability to at runtime switch between alsa and jack audio+midi driver.
Changes
class design changes
Before:
After:
Audio Tests
Midi tests
Optional cleanups / redesign
Remove LinuxAudioDriver and keep only AlsaAudioDriver and JackAudioDriver as two independent implementations. To switch between them, you need to add another class, something like IAudioDriverProvider. This is what you need to add to IoC (and remove the drivers from IoC). Access the driver through this class, like:
This greatly simplifies everything, each class becomes simple and does one thing.
Moreover, such a system is easily scalable; we can easily add other drivers, cross-platform or platform-specific.
Not in scope for this PR
Known cleanups & fixes before merge
Misc. needed for jack #22373
If possible do mutual dependency Injection between module Audio and Midi.Testing confirmed, can't inject modules.
Injection is used, but not at modul level.
No 'requires restart' added
automatic connection to audio ports upon startNot in scope, brings in too much arbitrary heuristics code from Mu3.