Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inverted noteBackgroundColor #22486

Closed
wants to merge 1 commit into from
Closed

Add inverted noteBackgroundColor #22486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/engraving/internal/engravingconfiguration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ Color EngravingConfiguration::thumbnailBackgroundColor() const

Color EngravingConfiguration::noteBackgroundColor() const
{
return Color::WHITE;
return notationConfiguration()->foregroundColor();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution is not ideal... It creates bad dependencies between the modules. The notation module should depend on the engraving module, and not vice versa

Copy link
Contributor Author

@Jojo-Schmitz Jojo-Schmitz Apr 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(no such concerns had been raised with the original PR)
How to change?

}

Color EngravingConfiguration::fontPrimaryColor() const
Expand Down
2 changes: 2 additions & 0 deletions src/engraving/internal/engravingconfiguration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
#include "modularity/ioc.h"
#include "global/iglobalconfiguration.h"
#include "ui/iuiconfiguration.h"
#include "notation/inotationconfiguration.h"
#include "accessibility/iaccessibilityconfiguration.h"
#include "importexport/guitarpro/iguitarproconfiguration.h"

Expand All @@ -37,6 +38,7 @@ class EngravingConfiguration : public IEngravingConfiguration, public muse::Inje
{
muse::Inject<muse::IGlobalConfiguration> globalConfiguration = { this };
muse::Inject<muse::ui::IUiConfiguration> uiConfiguration = { this };
muse::Inject<mu::notation::INotationConfiguration> notationConfiguration = { this };
muse::Inject<muse::accessibility::IAccessibilityConfiguration> accessibilityConfiguration = { this };
muse::Inject<iex::guitarpro::IGuitarProConfiguration> guitarProConfiguration = { this };

Expand Down
Loading