Fix MSVC Compiler warnings #26311
Merged
Fix MSVC Compiler warnings #26311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jojo-Schmitz
commented
Feb 3, 2025
•
Jojo-Schmitz
commented
- reg.: 'initializing': conversion from 'size_t' to 'int', possible loss of data (C4267)
- reg.: declaration of 'tourId' hides function parameter (C4457)
- reg.: declaration hides previous local declaration (C4456)
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
10 times, most recently
from
76726f8 to
ee24f69
Compare
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
8 times, most recently
from
4a876ec to
a690f03
Compare
reg.: conversion from 'size_t' to 'int', possible loss of data (C4267)
reg.: declaration of 'tourId' hides function parameter (C4457)
reg.: declaration hides previous local declaration (C4456)
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
from
a690f03 to
00130fc
Compare
cbjeukendrup
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.