Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment corrections with accidentals of different sizes #26457

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

mike-spa
Copy link
Contributor

@mike-spa mike-spa commented Feb 12, 2025

Resolves: #24043

  • Accidentals are aligned by their right side, not by their left (which obvs is only relevant if they have different size)
  • Accidentals of different scale are not aligned unless the option for "Align offset octaves" is turned on

@mike-spa mike-spa requested a review from oktophonie February 12, 2025 11:33
This is only relevant for accidentals with different mag, see musescore#24043, otherwise aligning by the left or right side makes no difference.
@mike-spa mike-spa force-pushed the alignAccidentalsToRightSide branch from ee18e65 to 6c988d2 Compare February 17, 2025 13:43
@oktophonie oktophonie added the vtests This PR produces approved changes to vtest results label Feb 17, 2025
@mike-spa mike-spa force-pushed the alignAccidentalsToRightSide branch from 6c988d2 to 31d5a1d Compare February 17, 2025 14:50
@mike-spa mike-spa force-pushed the alignAccidentalsToRightSide branch from 31d5a1d to d734506 Compare February 18, 2025 08:23
@oktophonie oktophonie requested a review from miiizen February 18, 2025 09:22
@miiizen miiizen merged commit 988016f into musescore:master Feb 18, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vtests This PR produces approved changes to vtest results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accidental alignment is not necessary between full-size and cue-size notes
3 participants