Percussion panel - refinements round 7 #26498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathesoncalum
force-pushed
the
percussion_refinements_7
branch
from
78ef429 to
4ede47b
Compare
cbjeukendrup
approved these changes
Feb 14, 2025
|
Tested on MacOS and approved |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refinements PR this time:
Commits b322781 and da116bc resolve the first point mentioned in #26490 (shift-clicking pads to make chords, shift-ctrl/cmd-clicking to insert)
Commit 29fecd5 resolves a bug where the sound preview was incorrect when adding notes over an instrument change (the fall-through is no longer needed after the first two commits in this PR).
Commit 4ede47b resolves #26361