Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update codestyle to uncrustify 0.74 #26501

Merged

Conversation

igorkorsukov
Copy link
Contributor

No description provided.

@igorkorsukov igorkorsukov marked this pull request as draft February 14, 2025 13:10
@igorkorsukov igorkorsukov force-pushed the repo/codestyle_update_250214 branch from 67e43c5 to cb3bc8f Compare February 17, 2025 08:24
@igorkorsukov igorkorsukov marked this pull request as ready for review February 17, 2025 08:24
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 17, 2025

How many existing PRs would now fail after getting merged, without a prior rebase and fix?

@igorkorsukov
Copy link
Contributor Author

How many existing PRs would now fail after getting merged, without a prior rebase and fix?

I think quite a lot, but that's the price of moving forward )
There are always a lot of PRs, there is no opportunity to wait for a better moment...
There are not many changes there, I believe that the authors will easily solve it.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 17, 2025

Problem is that, without a rebase, we'd find out too late, i.e. after the merge

@igorkorsukov
Copy link
Contributor Author

Problem is that, without a rebase, we'd find out too late, i.e. after the merge

I will monitor and fix it...

@Jojo-Schmitz
Copy link
Contributor

I'll rest my case then ;-)

@igorkorsukov igorkorsukov merged commit ea94b05 into musescore:master Feb 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants