Change Decrescendo to Diminuendo #26522

Jojo-Schmitz · 2025-02-15T12:27:34Z

As much as possible, variable names and comments as well as (transatable) texts

While both, "Decrescendo" and "Diminuendo", are valid terms for the same thing, "Diminuendo" is a better match for "dim." (like "Crescendo" and "cresc."), isn't based on just forming the opposite (of "Crescendo") by prefixing a "De" and also is (slightly) shorter

src/importexport/mei/tests/data/hairpin-01.mei

Jojo-Schmitz · 2025-02-15T13:32:40Z

src/importexport/guitarpro/internal/gtp/gp67dombuilder.cpp

@@ -557,8 +557,8 @@ std::pair<int, std::shared_ptr<GPBeat> > GP67DomBuilder::createGPBeat(XmlDomNode
    auto hairpinType = [](const String& str) {
        if (str == u"Crescendo") {
            return GPBeat::Hairpin::Crescendo;
-        } else if (str == u"Decrescendo") {
-            return GPBeat::Hairpin::Decrescendo;
+        } else if (str == u"Decrescendo") { // this is what GTP calls it internally


Seem here we need to keep the string, for GTP import to work.
Else some (well, 3) unit tests fail.

Jojo-Schmitz · 2025-02-15T13:40:06Z

src/importexport/capella/internal/capxml.cpp

@@ -669,7 +669,7 @@ void TrillObj::readCapx(XmlReader& e)
 void WedgeObj::readCapx(XmlReader& e)
 {
    // TODO: read LineObj properties
-    decresc          = e.asciiAttribute("decrescendo", "false") == "true";
+    dim              = e.asciiAttribute("decrescendo", "false") == "true"; // this is what Capella calls it internally


Seem here we need to keep the string, for Capella import to work.
This case doesn't seem to be covered by any unit tests though.

src/importexport/ove/internal/importove.cpp

src/importexport/ove/internal/ove.cpp

src/importexport/ove/internal/ove.h

As much as possible

Jojo-Schmitz changed the title ~~Change Decrescendo to Diminiendo~~ Change Decrescendo to Diminuendo Feb 15, 2025

Jojo-Schmitz force-pushed the decrescendo2diminuendo branch 2 times, most recently from ce708e0 to cc5935f Compare February 15, 2025 13:25

Jojo-Schmitz commented Feb 15, 2025

View reviewed changes

src/importexport/mei/tests/data/hairpin-01.mei Show resolved Hide resolved

Jojo-Schmitz commented Feb 15, 2025

View reviewed changes

src/importexport/mei/tests/data/hairpin-01.mei Show resolved Hide resolved

Jojo-Schmitz force-pushed the decrescendo2diminuendo branch from cc5935f to e27e157 Compare February 15, 2025 13:31

Jojo-Schmitz commented Feb 15, 2025

View reviewed changes

Jojo-Schmitz force-pushed the decrescendo2diminuendo branch from e27e157 to 63ae717 Compare February 15, 2025 13:38

Jojo-Schmitz commented Feb 15, 2025

View reviewed changes

Jojo-Schmitz marked this pull request as ready for review February 15, 2025 13:43