Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update in-repo translation source files #26531

Merged
merged 2 commits into from
Feb 16, 2025
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Run lupdate with arguments -no-obsolete

@github-actions github-actions bot added the strings Affects translatable strings label Feb 16, 2025
<location filename="../../src/notation/view/noteinputbarmodel.cpp" line="532"/>
<source>Add</source>
<extracomment>Keep in sync with the message that appears if there are no instruments in the score (LayoutPanel.qml)</extracomment>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomanPudashkin I have some reservations about putting strings in the global context:

  • When one occurrence has an extra comment, like here, that comment is of course only relevant for that single occurrence, but if all occurrences appear as one string on Transifex, that's problematic of course
  • Ensuring consistent translations across the app is not our task. That's the task of the translators, and Transifex has plenty of tools to assist in that.
  • On the contrary: in different places, the same string may need different translations, so we need to give translators the ability to do that.
  • Because Transifex automatically fills in translations for other occurrences of the same string in different contexts if the translator doesn't do that themselves, having multiple occurrences of the same string does not create more work for translators.
  • In the list of all strings on Transifex, the strings are sorted in such way that strings that appear close to each other in the code are listed close to each other. So, if you have a dialog, all strings in that dialog are listed close to each other, but if there's one button in the dialog whose text is in the global context, the text of that string will be in a totally different place in the list, making it more difficult to keep the overview.

@cbjeukendrup cbjeukendrup merged commit 690b0c8 into master Feb 16, 2025
11 checks passed
@cbjeukendrup cbjeukendrup deleted the ci_lupdate_master branch February 16, 2025 14:43
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 16, 2025

Wouldn't these changes need to get pushed to Transifex?

@cbjeukendrup
Copy link
Contributor

Ah yes, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
strings Affects translatable strings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants