Strings: consistently use "system markings", and write out "rehearsal marks" #26534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…marks" instead of just "rehearsal" which makes no sense
cbjeukendrup
changed the title
mike-spa
approved these changes
Feb 18, 2025
| <source>Add instruments or system markings</source> | ||
| <translation type="unfinished">Add instruments or system markings</translation> | ||
| <source>Add instruments or system objects</source> | ||
| <translation type="unfinished">Add instruments or system objects</translation> |
There was a problem hiding this comment.
This change doesn't seem consistent at all, just the contrary !?!
There was a problem hiding this comment.
Ah, I didn't run lupdate in my second commit. Anyway, #26578 fixes it. Also pushed to Tx already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…instead of just "rehearsal" which makes no sense
Resolves: #26533