Fix flip then undo on drum staff #26552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Feb 17, 2025
miiizen
force-pushed
the
25788-prc-flip
branch
from
fe18670 to
c7720eb
Compare
zacjansheski
approved these changes
Feb 18, 2025
mike-spa
approved these changes
Feb 18, 2025
miiizen
force-pushed
the
25788-prc-flip
branch
from
c7720eb to
06ad4b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #25788
When a beam's direction was reset to
AUTOitsupvalue was being set by its first chord's staleupvalue. This is calculated first, so when the stem direction of the chord was calculated, it took the beam's direction (its own stale value).This only applied to drum staves. As drumkits have a direction specified for each pitch, beams now take their direction from their first chord's default direction.