Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System object correction #26555

Merged
merged 3 commits into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/engraving/dom/engravingitem.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ staff_idx_t EngravingItem::effectiveStaffIdx() const

staff_idx_t nextSystemObjectStaff = muse::nidx;
const std::vector<Staff*>& systemObjectStaves = m_score->systemObjectStaves();
for (size_t i = 1; i < systemObjectStaves.size(); ++i) {
for (size_t i = 0; i < systemObjectStaves.size(); ++i) {
staff_idx_t idx = systemObjectStaves[i]->idx();
if (idx > originalStaffIdx) {
nextSystemObjectStaff = idx;
Expand Down
2 changes: 1 addition & 1 deletion src/engraving/dom/utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1470,7 +1470,7 @@ std::vector<EngravingItem*> collectSystemObjects(const Score* score, const std::

for (const Measure* measure = score->firstMeasure(); measure; measure = measure->nextMeasure()) {
for (EngravingItem* measureElement : measure->el()) {
if (!measureElement || !measureElement->systemFlag()) {
if (!measureElement || !measureElement->systemFlag() || measureElement->isLayoutBreak()) {
continue;
}
if (!staves.empty()) {
Expand Down
2 changes: 1 addition & 1 deletion src/instrumentsscene/view/systemobjectslayertreeitem.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ static bool isLayerVisible(const SystemObjectGroups& groups)
}
}

return true;
return false;
}

SystemObjectsLayerTreeItem::SystemObjectsLayerTreeItem(IMasterNotationPtr masterNotation, INotationPtr notation, QObject* parent)
Expand Down
Loading