Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuItem API exposes checkable property directly #26571

Merged

Conversation

saintmatthieu
Copy link
Contributor

@saintmatthieu saintmatthieu commented Feb 18, 2025

Resolves: audacity/audacity#8268

The AbstractMenuModel implements its entire tree with MenuItems, which only allow setting the checkmark via an Action.
While it makes some sense that menu leaves are associated with actions, it does not for their parents, and hence MenuItems should give access to their checked state without having to modify the action (at least not at API level).

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@saintmatthieu saintmatthieu force-pushed the MenuItem-checkable-without-action branch from dde30b9 to 39c7730 Compare February 18, 2025 14:02
@igorkorsukov igorkorsukov merged commit 15e88d1 into musescore:master Feb 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants