System object correction #26588
System object correction #26588
Conversation
Don't add system object layers to the partIdList, otherwise we get duplicate IDs
The condition was not met when undoing a move-up-system-layer command so the UI wasn't updating.
| @@ -178,6 +178,7 @@ void SystemObjectsLayerTreeItem::onUndoStackChanged(const mu::engraving::ScoreCh | |||
| } | |||
|
|
|||
| if (shouldUpdateState) { | |||
| m_systemObjectGroups = collectSystemObjectGroups(m_staff); | |||
There was a problem hiding this comment.
I'm afraid this change will have a negative impact on performance. It scans the entire score for system objects, and we will now call it every time when the user adds / removes / changes a system object. On a small score it doesn't matter as much, but on a larger one it may be more noticeable
There was a problem hiding this comment.
20250220_153116.mp4
This was the problem I was trying to solve. Dragging a system object layer on another should cancels one of them, which means the remaining one needs to update its elements and state. I've tried a different solution in the last commit, could you tell me if that looks better?
There was a problem hiding this comment.
Looks better, thank you! However, it can be optimized even further: instead of scanning each staff one by one, we can call collectSystemObjectGroups for all of them (outside of the for loop) and update the state of the items. But it's rather nice to have :)
even for the already existing ones
Resolves: #26580