Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing forward declarations and #includes #26624

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

ephemer
Copy link
Contributor

@ephemer ephemer commented Feb 20, 2025

When building a non-standard build, certain files are missing type definitions. This PR adds the missing includes and forward declarations to allow building these files, even if they're built under different circumstances.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup cbjeukendrup merged commit e47441d into musescore:master Feb 21, 2025
11 checks passed
@ephemer ephemer deleted the correctness branch February 22, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants