fix: wrong repeats import for gp5 files #26655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikekirin
commented
Feb 21, 2025
| @@ -923,6 +923,11 @@ void GuitarPro::createMeasures() | |||
| // m->setRepeatFlags(bars[i].repeatFlags); | |||
| m->setRepeatCount(bars[i].repeats); // supported in gp5 | |||
|
|
|||
| if (bars[i].repeatFlags == (mu::engraving::Repeat::START | mu::engraving::Repeat::END)) { | |||
There was a problem hiding this comment.
If we not check this, we will ignore the cases when one bar has repeat start and repeat end.
mikekirin
commented
Feb 21, 2025
| @@ -923,7 +923,7 @@ bool GuitarPro5::read(IODevice* io) | |||
| } | |||
| if (barBits & SCORE_REPEAT_END) { // number of repeats | |||
| bar.repeatFlags = bar.repeatFlags | mu::engraving::Repeat::END; | |||
| bar.repeats = readUInt8() + 1; | |||
There was a problem hiding this comment.
The idea is correct, but we have to do that for volta endings, not the bar repeats
There was a problem hiding this comment.
Do we need the same change for other GP readers?
There was a problem hiding this comment.
Possibly. I will check them first and make separate PR if needed.
RomanPudashkin
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.