Send playback position in samples to VST plug-ins #26663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing forward declarations and #includes
Text fix: customisations -> customizations This fix was OK. Greetings, Gootector
Update in-repo translation source files
"Operator '?:' has lower precedence than '+'; '+' will be evaluated first" Introduced by 6205752
…_on_vbox Fix crash with page break on vertical frame
…gfix Fix Clang warning and potential bug
Correct measure rest placement with courtesy time signature above stave
| @@ -202,6 +203,10 @@ samples_t VstSynthesiser::process(float* buffer, samples_t samplesPerChannel) | |||
|
|
|||
| const msecs_t nextMsecs = samplesToMsecs(samplesPerChannel, m_sampleRate); | |||
| const VstSequencer::EventSequenceMap sequences = m_sequencer.movePlaybackForward(nextMsecs); | |||
|
|
|||
| // TODO: this is not a good way of doing this, please comment! | |||
| m_vstAudioClient->setPlaybackPosition(m_sequencer.playbackPosition()); | |||
There was a problem hiding this comment.
You can add the playback position as an argument to VstAudioClient::process:
muse::audio::samples_t process(float* output, muse::audio::samples_t samplesPerChannel, muse::audio::msecs_t playbackPosition = 0);
That would be a little simpler
|
Thanks for your contribution! Please rebase your PR to keep only 1 commit |
…dola/MuseScore into playbackPositionToVSTPlugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #26577
The idea behind this PR is to report playback position in samples to VST plug-ins. I'm a plug-in developer, this PR is just to start the conversation, it's definitely not a final solution. Please feel free to comment on how we should go about this