Implement the pass through #172
Open
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glaslos could you please have a check? |
glaslos
requested changes
Feb 15, 2025
| @@ -37,6 +38,10 @@ type Rule struct { | |||
| matcher *pcap.BPF | |||
| } | |||
|
|
|||
| func (r *Rule) GetRuleType() RuleType { | |||
There was a problem hiding this comment.
Make the attribute public instead of implementing a getter
| @@ -29,6 +29,8 @@ rules: | |||
| - match: tcp dst port 11211 | |||
| type: conn_handler | |||
| target: memcache | |||
| - match: tcp dst port 5000 | |||
There was a problem hiding this comment.
have you tested this for other ports?
There was a problem hiding this comment.
there is a problem, i have to set glutton run a specific port and implement pass through on the same port so that it works. so, i just wonder if gluuton could run a different port with pass through, i tested this situation but it shows connection refused. Also， when i test pass through within glutton running on the same port, it will accept request, but do not response, i don't if it is because i do not run any program on that port.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement passthrough so when you try to access a specific port, it will not set a handler for this port, and it just pass traffic to the target server not glutton