-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic updating of the Cask tap #9
base: main
Are you sure you want to change the base?
Automatic updating of the Cask tap #9
Conversation
…ha256 on the files
To prevent issues with tests
To prevent potentially committing .tar.gz files to be commited into the repository
919614d
to
3ff3b3d
Compare
3ff3b3d
to
4f0454a
Compare
@arctixdev this is ready for review 😊 Edit: The only thing I do not understand is that
|
9c6ae91
to
bcbe118
Compare
bcbe118
to
95009a5
Compare
Yeah thats weird, I ended up install shellcheck locally and running with the check enabled https://www.shellcheck.net/wiki/SC2312 |
No problem! I'm glad to help out. If there are any questions or issues, do not hesitate to reach out 😊 |
Description
This PR adds to the functionality to automatically update the tap based on the latest Github release.
Note, I've specifically based this PR on a previous version of the repository, for demonstration purposes.
Example commit: sandervankasteel@919614d
Questions / notes :
Do pre-releases happen?
Because that might require some work in the script to prevent issue with releasing pre-release tags.
For the moment I've set the schedule to run every 2 hours, but I'm not sure if that's too often or not. Since I do not have any visibility on the CI minute usage of the
music-assistant
organization