Skip to content

CSS complete #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

CSS complete #71

wants to merge 5 commits into from

Conversation

pjebs
Copy link

@pjebs pjebs commented Sep 15, 2018

Used https://play.golang.org/p/uK-9pocUmVE
Only CSS 3 are included.

@pjebs
Copy link
Author

pjebs commented Sep 15, 2018

I added the attributes for html input element.

Can you double check it because I didn't quite understand Attr what the html field was meant to be for.

What I did was:

  1. Got the supported fields from https://godoc.org/honnef.co/go/js/dom#HTMLInputElement
  2. Processed them using this code (can you double check please): https://play.golang.org/p/jBzxwYzDjgl
  3. Copied and Pasted and then ran gofmt
  4. Human verified it to the best of my ability

@pjebs
Copy link
Author

pjebs commented Sep 15, 2018

You can see for ValueAsDate I was unsure what to do with a time.Time object.
For ValueAsNumber I was unsure what to do with the type being float64

Re: lowercase for html attribute - https://stackoverflow.com/questions/36176474/camel-case-in-html-tag-attributes-and-jquery-doesnt-work-why

textarea, option, img, iframe, form, button
@pjebs
Copy link
Author

pjebs commented Sep 16, 2018

I added more stuff but was a bit unsure how to deal with events. commit: 1483549

@pjebs
Copy link
Author

pjebs commented Sep 16, 2018

iframe.srcdoc may need to be checked too

@pjebs
Copy link
Author

pjebs commented Sep 24, 2018

@myitcv Are there any concerns, suggestions or feedback about this PR?

@myitcv
Copy link
Owner

myitcv commented Sep 27, 2018

@pjebs I'm trying to find time to look through this, apologies for the delay.

@Woellchen
Copy link

bump. would like to see that merged :)

@pjebs
Copy link
Author

pjebs commented Oct 23, 2018

@Woellchen I got it merged in my new package: https://medium.com/@rocketlaunchr.cloud/go-with-react-de5ee4f01df9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants