More formulas and easier formula editing #363

jkirschner · 2020-09-10T21:24:46Z

Important Changes

More Formulas: Replaced x-spreadsheet's custom formula parser with the MIT licensed' hot-formula-parser based on a fork of formula.js. This makes most formulas available in Excel also available in x-spreadsheet.
Easier Formula Editing: When editing a formula, click to select a cell OR click and drag to select a range. Single cell and range selections can then be modified with arrow keys with or without the SHIFT key to respectively expand/shrink or move the selection.
Absolute Cell References: Absolute cell references are explicitly supported, including when a formula cell is copied by clicking and dragging the anchor in the bottom-right corner.
Translation Fallback: If a translation is attempted but no associated key exists in the primary locale, the application can use fallback locale(s). The default fallback locale is English but this can be overridden when specifying a locale to use.

Known Limitations

I recommend accepting this PR while acknowledging there is room for improvement. These improvements are all limitations of formula.js rather than of its integration into x-spreadsheet:

Some formulas in formula.js don't have the same flexibility as they do in Excel. For example, in Excel, COUNTIF(A1:A5, "a") returns how many cells in that range contain the letter "a" (with the asterisk allowing any number of characters before or after "a"). But in formula.js, regex characters like "*" don't work. Instead, formula.js will return how many cells in that range have the exact value "a".

Merge Notes
This PR includes commits from a different fork for which a PR was also submitted: #309

If this PR is accepted and merged, PR 309 should be closed without merging.

Known Resolved Issues
#362 - more formulas
#320 - more formulas
#280 - only difference being that it's just click, not shift click

Note: I can only understand the issues written in my native language (English), so there may be others I am missing.

codecov · 2020-09-10T21:28:33Z

Codecov Report

Merging #363 (8a2f8ff) into master (549f5cf) will not change coverage.
The diff coverage is n/a.

❗ Current head 8a2f8ff differs from pull request most recent head 597b095. Consider uploading reports for the commit 597b095 to get more accurate results

@@      Coverage Diff      @@
##   master   #363   +/-   ##
=============================
=============================

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 549f5cf...597b095. Read the comment docs.

jkirschner · 2020-09-17T14:01:06Z

Merge conflict introduced by recent update to master has been resolved

jkirschner · 2020-09-17T14:03:46Z

@myliang and team: ready for your consideration

jkirschner · 2020-09-17T20:17:47Z

I see that my PR currently fails the code coverage check. I'm wondering whether this was mostly caused by removing the formula tests (since, in this PR, formula parsing/calculation is now handled by library code rather than x-spreadsheet). I'll see if I can increase the number of tests in general, but I only feel comfortable writing tests for code I touched (and I'm not sure that will bring the test percentage up enough to pass the check).

jkirschner · 2020-09-28T02:50:25Z

@myliang : I have improved the test coverage since my last comment. alphabet.js now has all functions covered, and I added tests for locale.js (which previously didn't have them).

Please review at your earliest convenience.

jkirschner · 2020-10-01T21:56:56Z

@myliang : is there anything I can do to facilitate a review by you or another project maintainer? I don't want to continue with additional changes until this PR has been reviewed, approved, and merged.

myliang · 2020-10-02T00:42:37Z

too big changes will not be accepted.

jkirschner · 2020-10-02T01:58:03Z

@myliang : I am happy to split this into several smaller PRs:

chieveit's original formula editing improvements -> Better Formula Editing (by ChieveiT) #382
npm run test fix -> Make 'npm run test' command cross-platform #380
locale improvements -> Improve locale flexibility #381
formula.js conversion
click and drag cell range selection

Would that be acceptable?

jkirschner · 2020-10-05T15:48:47Z

@myliang : I've separated out some of the functionality into smaller PRs:

npm run test fix -> Make 'npm run test' command cross-platform #380
locale improvements -> Improve locale flexibility #381

Once those are reviewed, approved, and merged, I'll create small PRs for the other functionality included in this large PR.

jkirschner · 2020-10-06T15:34:40Z

@myliang : thanks for the review on 380 and 381. Another smaller PR is now ready for your review:

chieveit's formula editing improvements -> Better Formula Editing (by ChieveiT) #382

Once that is reviewed, approved, and merged, I'll move on to creating a PR for formula.js integration.

mm738 · 2020-10-16T01:48:34Z

On this branch: https://github.com/jkirschner/x-spreadsheet/tree/formulajs-range-selection

@myliang and @jkirschner this is a great feature update!

This makes it more like how Excel works.
Another good feature is dragging and dropping cells from one place to another. Very common feature.

Thanks.

jkirschner · 2020-10-16T11:09:27Z

Thanks @mm738. Trying to work with the maintainers to get this integrated upstream in parts (since this PR was too large). So far we are 2/5 of the way there!

harlan3 · 2020-10-16T20:55:59Z

jkirschner this is a great improvement wrt formula calculations within the worksheet. With the old implementation, simple calculations resulted in erroneous values. However, your formulajs branch in its current state breaks document printing. The references to "this" formulaParser within the renderCell function call are invalid in src/component/table.js

ThibautSF · 2021-01-14T09:05:30Z

I report a possible bug for @jkirschner here (hope this is the place)
On this branch: https://github.com/jkirschner/x-spreadsheet/tree/formulajs-range-selection

If I use the formula selector, any formula will write "=undefined()" in the cell instead of the correct formula.

Note that it's still possible to select formulas from the cell completion suggestions.

pbadenski · 2021-02-15T18:03:19Z

This is a very powerful feature and I'm sad to see is not progressing - what can be done to help?

harlan3 · 2021-02-15T19:51:27Z

I believe the project owner is not interested in incorporating this functionality unfortunately. In my opinion, it is a huge improvement. It does break some things like printing that needs to be addressed. Best regards, Harlan

…

________________________________ From: Pawel Badenski <[email protected]> Sent: Monday, February 15, 2021 1:03 PM To: myliang/x-spreadsheet <[email protected]> Cc: harlan3 <[email protected]>; Comment <[email protected]> Subject: Re: [myliang/x-spreadsheet] More formulas and easier formula editing (#363) This is a very powerful feature and I'm sad to see is not progressing - what can be done to help? — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#363 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AF3GHP7ZPFPTIFPQOWZXIW3S7FOXTANCNFSM4RF43UUA>.

jkirschner · 2021-02-20T21:43:31Z

@pbadenski, @harlan3 : I started breaking this large PR up into smaller PRs upon request by the project owner. One of these smaller PRs is still awaiting review/approval/merge: #382. Perhaps the next step is getting that PR through.

Unfortunately, I have a lot less time now than I did when I originally created this PR. I can't push it forward right now (e.g., fix the printing bug), but I do want to come back to it eventually.

jkirschner · 2021-05-13T15:18:54Z

@pbadenski, @harlan3, @ThibautSF, @myliang : I have some time over the next week to push this PR forward and hopefully get it through the review process. My understanding from the maintainer is that it needs to be broken up into smaller PRs which can then be individually reviewed and merged. I'm partway through that process: the latest PRs to review are #382, #464, #465, and #466.

harlan3 · 2021-05-28T21:55:21Z

@jkirschner Thanks for the effort but I've tested this PR a lot and there fundamental issues with it that cannot be solved easily. Just saying cause don't want you to waste your time.

x-datasheet doesn't handle smart formula parsing. I.e it loops through all cells in a linear order, it does not build any graphs. This means when changing cell dependents it wont update cells in the correct order. I'm not sure if hot-formula parser does build the graph correctly but when I tested this PR it was very laggy.

The parsing of the formulas in this PR is done on every render of the cell. This isn't efficient. It should be done once and cached and not on every render.

Due to the above issues the spreadsheets lags with any reasonable amount of formulas or circle references.

I have been using the @jkirschner branch for several months now (along with some additional improvements for loading and saving files) and I would say it is vastly superior in comparison to the x-spreadsheet that doesn't have smart formula parsing. I have used it with spreadsheets spanning several hundred cells and it does slow down some but for a "normal" sized spreadsheet it is fine. If you have something better then you should submit it back to git master and the code should fall under the MIT license as the original project uses the MIT. It isn't right that you leverage all the code to x-spreadsheet and then not contribute your work back to the project. That is completely unethical. I am perfectly happy using the @jkirschner branch. It is just unfortunate that it has not been promoted into the git master yet.

ThibautSF · 2021-05-29T07:34:51Z

And just at a UX level, this PR is way better. Formula edition alongside absolute cell reference gives a better end-user experience, near enough of what you can expect on a desktop sheet and simple enough for a integrated web use (didn't find anything better for now in other open source sheet libraries).

X-spreadsheet is really good, this PR made it just better. It sure has drawbacks in case of big sheets, but those can be solved with code review, suggestions and improvements.

MartinDawson · 2021-05-29T08:51:59Z

I can’t. The solution uses a paid package which is not MIT to do the calculations. Hot formula parser is not maintained anymore Also, it’s a complete rewrite so it’s never going to be approved by the maintainer

…

On Fri, 28 May 2021 at 22:55, harlan3 ***@***.***> wrote: @jkirschner <https://github.com/jkirschner> Thanks for the effort but I've tested this PR a lot and there fundamental issues with it that cannot be solved easily. Just saying cause don't want you to waste your time. 1. x-datasheet doesn't handle smart formula parsing. I.e it loops through all cells in a linear order, it does not build any graphs. This means when changing cell dependents it wont update cells in the correct order. I'm not sure if hot-formula parser does build the graph correctly but when I tested this PR it was very laggy. 2. The parsing of the formulas in this PR is done on every render of the cell. This isn't efficient. It should be done once and cached and not on every render. Due to the above issues the spreadsheets lags with any reasonable amount of formulas or circle references. I have been using the @jkirschner <https://github.com/jkirschner> branch for several months now (along with some additional improvements for loading and saving files) and I would say it is vastly superior in comparison to the x-spreadsheet that doesn't have smart formula parsing. I have used it with spreadsheets spanning several hundred cells and it does slow down some but for a "normal" sized spreadsheet it is fine. If you have something better then you should submit it back to git master and the code should fall under the MIT license as the original project uses the MIT. It isn't right that you leverage all the code to x-spreadsheet and then not contribute your work back to the project. That is completely unethical. I am perfectly happy using the @jkirschner <https://github.com/jkirschner> branch. It is just unfortunate that it has not been promoted into the git master yet. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#363 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADSVRWZCXP6IJTFVXYX3GFTTQAGNPANCNFSM4RF43UUA> .

Replace existing formula parsing and execution with an external parser library built on top of formula.js: https://github.com/handsontable/formula-parser This dramatically increases the number of supported formulas; see list here: https://formulajs.info/functions/

With the inclusion of many formulas from formula.js, the number of formula options is now too great to display without a scrollable container.

Formula keys within locale files should match the name of the formulajs function that a translation string is being provided for. If a formula name has a '.' in it, it should be escaped as follows: { "FORMULA\\.NAME": "TRANSLATION" }

Absolute cell references are evaluated correctly. When dragging the bottom-right corner of a formula cell to copy its contents to other cells, absolute cell references will be incremented or decremented appropriately (only relative axes will be modified, not absolute). When adding or removing rows or columns, absolute cell references will be adjusted appropriately.

The initial click sets the cell reference range start position. If the click is held, the cell reference range end position is updated on mouse move. The cell reference range can then be modified in the same ways as a single cell reference (e.g., arrow keys).

If the user is editing a cell reference range within a formula and is holding the shift key while using the direction arrows to move the range, the start of the range will be fixed. This mirrors the behavior of Excel when editing a cell reference range.

jkirschner · 2021-05-30T01:09:11Z

@jkirschner Thanks for the effort but I've tested this PR a lot and there fundamental issues with it that cannot be solved easily. Just saying cause don't want you to waste your time.

x-datasheet doesn't handle smart formula parsing. I.e it loops through all cells in a linear order, it does not build any graphs. This means when changing cell dependents it wont update cells in the correct order. I'm not sure if hot-formula parser does build the graph correctly but when I tested this PR it was very laggy.

The parsing of the formulas in this PR is done on every render of the cell. This isn't efficient. It should be done once and cached and not on every render.

Due to the above issues the spreadsheets lags with any reasonable amount of formulas or circle references.

@MartinDawson : Can you help me understand how either of those concerns is related to this PR? If I understand correctly, (1) looping through all cells in a linear order and (2) parsing formulas on every render of the cell were both behaviors of x-spreadsheet before this PR. This PR changes the parsing engine for formulas, but not when parsing is performed.

Yes, improvements to efficiency can be made, but those should be done in a separate PR.

jkirschner · 2021-07-05T11:48:47Z

@harlan3, @ThibautSF: because of @MartinDawson 's comments, I put together a proof-of-concept that builds on this PR to (1) perform efficient recalculations and (2) detect circular references: https://github.com/jkirschner/x-spreadsheet/tree/efficient-recalculation

Let me know if you try that branch out and see a significant enough performance improvement that it's worth me finishing the branch. I still need to make some small fixes (such as to print mode) and significantly cleanup the commit history via rebasing, so I wouldn't use the efficient-recalculation branch yet... but it's ready to try out!

harlan3 · 2021-07-05T18:28:59Z

@harlan3, @ThibautSF: because of @MartinDawson 's comments, I put together a proof-of-concept that builds on this PR to (1) perform efficient recalculations and (2) detect circular references: https://github.com/jkirschner/x-spreadsheet/tree/efficient-recalculation

Let me know if you try that branch out and see a significant enough performance improvement that it's worth me finishing the branch. I still need to make some small fixes (such as to print mode) and significantly cleanup the commit history via rebasing, so I wouldn't use the efficient-recalculation branch yet... but it's ready to try out!

I tried it with some minimal testing, and it seemed to work ok. To really test it I would need to merge in my spreadsheet file loading and saving capability which would allow the loading of large x-spreadsheet files. If you are interested in putting the file loading and saving functionality in your main baseline let me know and I will create a branch for a PR.

jkirschner · 2021-07-06T12:07:05Z

I tried it with some minimal testing, and it seemed to work ok. To really test it I would need to merge in my spreadsheet file loading and saving capability which would allow the loading of large x-spreadsheet files. If you are interested in putting the file loading and saving functionality in your main baseline let me know and I will create a branch for a PR.

@harlan3 : I probably won't merge any PRs, including my own, into my fork's main branch because I'm trying to keep that consistent with upstream - which relies on getting things merged upstream. If you submit a PR against the main branch, I'll probably take those commits and place them on top of efficient-recalculation to create a new branch that you can test in. Or, you could create a PR against efficient-recalculation yourself!

It's worth doing that so we can test the performance improvements and see if it's worth pursuing further. Thanks!

harlan3 · 2021-07-07T01:35:00Z

I tried it with some minimal testing, and it seemed to work ok. To really test it I would need to merge in my spreadsheet file loading and saving capability which would allow the loading of large x-spreadsheet files. If you are interested in putting the file loading and saving functionality in your main baseline let me know and I will create a branch for a PR.

@harlan3 : I probably won't merge any PRs, including my own, into my fork's main branch because I'm trying to keep that consistent with upstream - which relies on getting things merged upstream. If you submit a PR against the main branch, I'll probably take those commits and place them on top of efficient-recalculation to create a new branch that you can test in. Or, you could create a PR against efficient-recalculation yourself!

It's worth doing that so we can test the performance improvements and see if it's worth pursuing further. Thanks!

I created a fork of your x-spreadsheet repo and merged in the changes for file loading and saving in my efficient-recalculation branch. You can clone it from here: https://github.com/harlan3/x-spreadsheet/tree/efficient-recalculation
To use the new feature, click on the "pen" icon which is on the far right of the toolbar. This toggles between the spreadsheet view and the JSON view of the table. To load the spreadsheet, copy and paste the contents of one of the files in the new sample_files directory such as loan_calc.txt. It is a pretty large file and I think your performance changes in this branch have helped out considerably.

vipulism · 2021-07-12T13:46:27Z

@jkirschner @harlan3 : is there any way to get parsed value programmatic ? likecellParsedValue(2,6)

ThibautSF · 2021-07-12T19:26:58Z

@jkirschner @harlan3 : is there any way to get parsed value programmatic ? likecellParsedValue(2,6)

I made this function (based on x-spreadsheet code and using the xspreadsheet cell(rowIndex, colIndex, sheetIndex) method) in order to get parsed value for any cell.

function getCellValue(xspreadsheet, rowIndex, colIndex, sheetIndex) {
    if (xspreadsheet) {
        if ((cell = xspreadsheet.cell(rowIndex, colIndex, sheetIndex))) {
            var cellText = cell.text;

            if (cellText && cellText[0] == "=") {
                cellText = xspreadsheet.sheet.table.formulaParser.parse(
                    cellText.slice(1)
                );

                cellText = cellText.result;
            }

            return Number(cellText) || cellText;
        }
    }
}

Note: xspreadsheet is the xspreadsheet instance object.

smazydev · 2021-10-05T15:21:55Z

This should've been merged a long time ago, such splendid work!

harlan3 · 2021-10-05T21:09:31Z

I agree totally! It is unfortunate that there are so many hoops to jump through.

…

-Harlan

________________________________ From: Ali Zafar ***@***.***> Sent: Tuesday, October 5, 2021 11:22 AM To: myliang/x-spreadsheet ***@***.***> Cc: harlan3 ***@***.***>; Mention ***@***.***> Subject: Re: [myliang/x-spreadsheet] More formulas and easier formula editing (#363) This should've been merged a long time ago, such splendid work! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#363 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AF3GHP2PJNLUFUKJ2T3ETILUFMJZ5ANCNFSM4RF43UUA>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

Tardo · 2022-05-19T16:53:39Z

This works fine... can you rebase and resolve the conflicts? We can supersed if not :)

jkirschner · 2022-05-22T22:53:10Z

Hi @Tardo,

The maintainer previously said they would not accept this PR as is because it was too large. That's very understandable, so I started the process of breaking it into many smaller PRs. The first few sub-PRs were merged. But the next few sub-PRs have not been reviewed. And there's a lot of work in this branch that hasn't made it into a sub-PR yet, because I was waiting for the existing sub-PRs to be merged.

A lot of time has since passed.

I cannot justify spending more time on this unless the maintainer expresses interest in this PR. And if that happens, I'm not sure I even have the bandwidth to pick this back up right now.

I really appreciate the feedback and collaboration I've had with the community members in this thread. I wish you the best of luck with your spreadsheets :)

harlan3 · 2022-05-23T00:21:47Z

That is a real shame that this functionality has not been allowed to be merged back into the master baseline. It makes x-spreadsheet MUCH more useable as a real-world spreadsheet capable of evaluating equations like Excel. I don't really buy the excuse that the PR is too large...who cares! It just takes a little longer to review the code. One large PR in my opinion is actually much easier to deal with than having to mess around with a bunch of smaller PRs and their dependencies on each other. As long the effort in the PR is all coherent with respect to an implemented feature it should have been accepted, in my opinion.

…

-Harlan

________________________________ From: Jared Kirschner ***@***.***> Sent: Sunday, May 22, 2022 6:53 PM To: myliang/x-spreadsheet ***@***.***> Cc: harlan3 ***@***.***>; Mention ***@***.***> Subject: Re: [myliang/x-spreadsheet] More formulas and easier formula editing (#363) Hi @Tardo<https://github.com/Tardo>, The maintainer previously said<#363 (comment)> they would not accept this PR as is because it was too large. That's very understandable, so I started the process of breaking it into many smaller PRs. The first few sub-PRs were merged. But the next few sub-PRs have not been reviewed. And there's a lot of work in this branch that hasn't made it into a sub-PR yet, because I was waiting for the existing sub-PRs to be merged. A lot of time has since passed. I cannot justify spending more time on this unless the maintainer expresses interest in this PR. And if that happens, I'm not sure I even have the bandwidth to pick this back up right now. I really appreciate the feedback and collaboration I've had with the community members in this thread. I wish you the best of luck with your spreadsheets :) — Reply to this email directly, view it on GitHub<#363 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AF3GHP4DQM4CECQQASTPOKLVLK3GJANCNFSM4RF43UUA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

Tardo · 2022-05-24T12:50:46Z

@jkirschner Thank you for your response and the work made here. Too bad the creator doesn't want to review/merge the PR... what matters are the commits :/ It's good to know how eager the maintainer is to include improvements in his repo...

MartinDawson · 2022-05-24T12:52:33Z

Guys, just use this canvas spreadsheet: https://github.com/glideapps/glide-data-grid

It's far better and not got 10,000 bugs in it.

And just use hyperformula as your cell engine parser

WeTruck · 2022-09-17T16:14:25Z

@smazydev how can I use xspreadsheet.js file from this pull request? Please help.

jkirschner marked this pull request as draft September 10, 2020 22:05

jkirschner force-pushed the formulajs-range-selection branch from f164400 to 8206342 Compare September 17, 2020 14:00

jkirschner marked this pull request as ready for review September 17, 2020 14:03

jkirschner force-pushed the formulajs-range-selection branch from 8206342 to c3e0dd2 Compare September 28, 2020 00:11

jkirschner marked this pull request as draft September 28, 2020 02:23

jkirschner force-pushed the formulajs-range-selection branch 2 times, most recently from c25618d to b70c5f9 Compare September 28, 2020 02:44

jkirschner marked this pull request as ready for review September 28, 2020 02:46

ThibautSF mentioned this pull request Feb 1, 2021

Fix undefined on formula toolbar selection jkirschner/x-spreadsheet#1

Open

Improve formula editing process within cells

ee61ed6

jkirschner marked this pull request as draft May 13, 2021 15:17

jkirschner force-pushed the formulajs-range-selection branch from b70c5f9 to 8a2f8ff Compare May 13, 2021 21:41

Jared Kirschner and others added 8 commits May 29, 2021 20:40

Make function dropdown content scrollable

e19a2b1

With the inclusion of many formulas from formula.js, the number of formula options is now too great to display without a scrollable container.

Update locale keys with formulajs function names

3981e88

Formula keys within locale files should match the name of the formulajs function that a translation string is being provided for. If a formula name has a '.' in it, it should be escaped as follows: { "FORMULA\\.NAME": "TRANSLATION" }

Improve test coverage of alphabet.js

0dc6d34

Add morph and translate methods to CellRange

ba99470

jkirschner force-pushed the formulajs-range-selection branch from 8a2f8ff to 597b095 Compare May 30, 2021 00:40

ThibautSF mentioned this pull request Jul 2, 2021

Support for navigator without navigator.clipboard.readText (besides IE) anhvutnu/x-spreadsheet#1

Open

myliang marked this pull request as ready for review May 30, 2022 01:20

WeTruck mentioned this pull request Sep 15, 2022

Better formula editing still unavailable? #618

Open

More formulas and easier formula editing #363

Are you sure you want to change the base?

More formulas and easier formula editing #363

Conversation

jkirschner commented Sep 10, 2020 • edited Loading

codecov bot commented Sep 10, 2020 • edited Loading

Codecov Report

jkirschner commented Sep 17, 2020

jkirschner commented Sep 17, 2020

jkirschner commented Sep 17, 2020

jkirschner commented Sep 28, 2020

jkirschner commented Oct 1, 2020

myliang commented Oct 2, 2020

jkirschner commented Oct 2, 2020 • edited Loading

jkirschner commented Oct 5, 2020

jkirschner commented Oct 6, 2020

mm738 commented Oct 16, 2020 • edited Loading

jkirschner commented Oct 16, 2020

harlan3 commented Oct 16, 2020 • edited Loading

ThibautSF commented Jan 14, 2021

pbadenski commented Feb 15, 2021

harlan3 commented Feb 15, 2021 via email

jkirschner commented Feb 20, 2021

jkirschner commented May 13, 2021

harlan3 commented May 28, 2021

ThibautSF commented May 29, 2021

MartinDawson commented May 29, 2021 via email

jkirschner commented May 30, 2021

jkirschner commented Jul 5, 2021

harlan3 commented Jul 5, 2021

jkirschner commented Jul 6, 2021 • edited Loading

harlan3 commented Jul 7, 2021

vipulism commented Jul 12, 2021 • edited Loading

ThibautSF commented Jul 12, 2021 • edited Loading

smazydev commented Oct 5, 2021

harlan3 commented Oct 5, 2021 via email

Tardo commented May 19, 2022

jkirschner commented May 22, 2022

harlan3 commented May 23, 2022 via email

Tardo commented May 24, 2022

MartinDawson commented May 24, 2022 • edited Loading

WeTruck commented Sep 17, 2022

jkirschner commented Sep 10, 2020 •

edited

Loading

codecov bot commented Sep 10, 2020 •

edited

Loading

jkirschner commented Oct 2, 2020 •

edited

Loading

mm738 commented Oct 16, 2020 •

edited

Loading

harlan3 commented Oct 16, 2020 •

edited

Loading

jkirschner commented Jul 6, 2021 •

edited

Loading

vipulism commented Jul 12, 2021 •

edited

Loading

ThibautSF commented Jul 12, 2021 •

edited

Loading

MartinDawson commented May 24, 2022 •

edited

Loading