new alerts front end #1851
Open
new alerts front end #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for doing DB things in development
Makes it easier to split out the different alert types on the alert page. Splits them into alerts with keywords, alerts for when someone speaks and alerts for the user's members.
To make it a bit easier to pick out the different parts of an alert update prettifyCritera to return the parts as a hash instead of turning it into a string.
used to store alert keyword suggestions based on related terms
If there's a square bracket in a get/post param then assume it's a multi value param and create/extend an array for the values so we can test forms with these.
Update constituency search to allow it to return all constituencies for a postcode instead of just westminster. Add a function to get a list of member ids from a search string.
Alert list splits alerts into keyword and representative alerts. New alert creation wizard which makes complicated alerts easier to create and also suggests related terms if we have any. Also allows editing alerts. Retains existing form for adding MP/postcode alerts.
This was referenced Dec 17, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Alerts front end. This has two sides:
The first is tidying up the display of alerts, splitting keyword and MP alerts into separate lists.
The second is a new alert sign up mechanism that makes it easier to use some of the more advanced features of alerts (limiting to a chamber, excluding terms) along with suggesting related terms where that makes sense. It also enables editing existing alerts.
MP alerts continue to use the existing mechanism.
Part of #1824