-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move iroh-router
into iroh-net
and rename iroh-net
to iroh
#2970
base: refactor-simple-iroh
Are you sure you want to change the base?
Conversation
ab6d95b
to
658ba3c
Compare
I highly recommend viewing this PR via its two individual commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can we move on now?
🤣 |
658ba3c
to
bbfacf5
Compare
iroh-router
into iroh-net
and rename iroh-net
to iroh
FWIW: If we want to merge this for real, we should make sure that both these PRs are rebased on main. There's some changes to e.g. the README missing on this branch. It's likely they'd get lost if we're not careful about rebasing. |
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2970/docs/iroh/ Last updated: 2024-11-27T14:59:51Z |
what about
|
Description
This merges
iroh-net
,iroh-router
andiroh
into simply one crate:iroh
.Breaking Changes
iroh-net
got renamed toiroh
iroh-router
moved intoiroh
iroh-router::ProtocolHandler
is nowiroh::protocol::ProtocolHandler
iroh-router::ProtocolMap
is nowiroh::protocol::ProtocolMap
iroh-router::Router
is nowiroh::router::Router
iroh-router::RouterBuilder
is nowiroh::router::RouterBuilder
Notes & open questions
Minor Q: Do the
iroh::protocol
andiroh::router
modules make sense?Change checklist