-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL JIT enhancements #1992
GraphQL JIT enhancements #1992
Conversation
🦋 Changeset detectedLatest commit: 7f29036 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
💻 Website PreviewThe latest changes are available as preview in: https://499131cb.envelop.pages.dev |
typeof pluginOptions.cache !== 'undefined' | ||
? pluginOptions.cache | ||
: new LRUCache<string, JITCacheEntry>({ max: DEFAULT_MAX, ttl: DEFAULT_TTL }); | ||
const jitCacheByDocumentString = pluginOptions.cache; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that the cache is now disabled by default ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we no longer provide a default LRU cache.
For Yoga, users can rely on the WeakMap based on DocumentNode which is cached by parser cache of Yoga itself.
🚀 Snapshot Release (
|
Package | Version | Info |
---|---|---|
@envelop/graphql-jit |
7.0.0-alpha-20231010181531-7f290367 |
npm ↗︎ unpkg ↗︎ |
@envelop/response-cache |
5.4.0-alpha-20231010181531-7f290367 |
npm ↗︎ unpkg ↗︎ |
@envelop/response-cache-redis |
3.4.0-alpha-20231010181531-7f290367 |
npm ↗︎ unpkg ↗︎ |
✅ Benchmark Results
|
graphql-jit
version until this is fixed; Support custom scalars in json serialiser zalando-incubator/graphql-jit#216enableIf
handling by replacingasync await
withvalue-or-promise
check