Skip to content

Commit

Permalink
Clean up includes
Browse files Browse the repository at this point in the history
Clean up includes so that osdep.h is included first and headers
which it implies are not included manually.

This commit was created with scripts/clean-includes, with the change
to target/s390x/gen-features.c manually reverted, and blank lines
around deletions collapsed.

Reviewed-by: Eric Blake <[email protected]>
Reviewed-by: Thomas Huth <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
Message-Id: <[email protected]>
  • Loading branch information
Markus Armbruster committed Feb 9, 2018
1 parent d8e39b7 commit 8f0a371
Show file tree
Hide file tree
Showing 30 changed files with 9 additions and 51 deletions.
1 change: 0 additions & 1 deletion block/parallels.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
#ifndef BLOCK_PARALLELS_H
#define BLOCK_PARALLELS_H
#include "qemu/coroutine.h"
#include "qemu/typedefs.h"

#define HEADS_NUMBER 16
#define SEC_IN_CYL 32
Expand Down
1 change: 0 additions & 1 deletion hw/block/vhost-user-blk.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include "qemu/osdep.h"
#include "qapi/error.h"
#include "qemu/error-report.h"
#include "qemu/typedefs.h"
#include "qemu/cutils.h"
#include "qom/object.h"
#include "hw/qdev-core.h"
Expand Down
3 changes: 1 addition & 2 deletions hw/nvram/eeprom_at24c.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@
* the LICENSE file in the top-level directory.
*/

#include <string.h>

#include "qemu/osdep.h"

#include "qapi/error.h"
#include "hw/hw.h"
#include "hw/i2c/i2c.h"
Expand Down
5 changes: 0 additions & 5 deletions hw/tpm/tpm_emulator.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,6 @@
#include "qapi/clone-visitor.h"
#include "chardev/char-fe.h"

#include <fcntl.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <stdio.h>

#define DEBUG_TPM 0

#define DPRINTF(fmt, ...) do { \
Expand Down
2 changes: 0 additions & 2 deletions hw/tpm/tpm_int.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
#ifndef TPM_TPM_INT_H
#define TPM_TPM_INT_H

#include "qemu/osdep.h"

#define TPM_STANDARD_CMDLINE_OPTS \
{ \
.name = "type", \
Expand Down
2 changes: 0 additions & 2 deletions hw/tpm/tpm_ioctl.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@
#ifndef _TPM_IOCTL_H_
#define _TPM_IOCTL_H_

#include <stdint.h>
#include <sys/uio.h>
#include <sys/types.h>
#include <sys/ioctl.h>

/*
Expand Down
1 change: 0 additions & 1 deletion hw/xtensa/xtensa_memory.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
#ifndef _XTENSA_MEMORY_H
#define _XTENSA_MEMORY_H

#include "qemu/osdep.h"
#include "qemu-common.h"
#include "cpu.h"
#include "exec/memory.h"
Expand Down
2 changes: 0 additions & 2 deletions include/exec/tb-lookup.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
#ifndef EXEC_TB_LOOKUP_H
#define EXEC_TB_LOOKUP_H

#include "qemu/osdep.h"

#ifdef NEED_CPU_H
#include "cpu.h"
#else
Expand Down
1 change: 0 additions & 1 deletion include/hw/intc/xlnx-pmu-iomod-intc.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
#ifndef XLNX_PMU_IO_INTC_H
#define XLNX_PMU_IO_INTC_H

#include "qemu/osdep.h"
#include "hw/sysbus.h"
#include "hw/register.h"

Expand Down
1 change: 0 additions & 1 deletion include/hw/intc/xlnx-zynqmp-ipi.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
#ifndef XLNX_ZYNQMP_IPI_H
#define XLNX_ZYNQMP_IPI_H

#include "qemu/osdep.h"
#include "hw/sysbus.h"
#include "hw/register.h"

Expand Down
1 change: 0 additions & 1 deletion include/hw/nvram/fw_cfg.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#ifndef FW_CFG_H
#define FW_CFG_H

#include "qemu/typedefs.h"
#include "exec/hwaddr.h"
#include "hw/nvram/fw_cfg_keys.h"
#include "hw/sysbus.h"
Expand Down
1 change: 0 additions & 1 deletion include/hw/pci-bridge/simba.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
* THE SOFTWARE.
*/

#include "qemu/osdep.h"
#include "hw/pci/pci_bridge.h"


Expand Down
2 changes: 0 additions & 2 deletions include/hw/xtensa/xtensa-isa.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
#ifndef XTENSA_LIBISA_H
#define XTENSA_LIBISA_H

#include <stdint.h>

#ifdef __cplusplus
extern "C" {
#endif
Expand Down
1 change: 0 additions & 1 deletion include/qapi/clone-visitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#ifndef QAPI_CLONE_VISITOR_H
#define QAPI_CLONE_VISITOR_H

#include "qemu/typedefs.h"
#include "qapi/visitor.h"
#include "qapi-visit.h"

Expand Down
2 changes: 0 additions & 2 deletions include/sysemu/hvf.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
#ifndef _HVF_H
#define _HVF_H

#include "config-host.h"
#include "qemu/osdep.h"
#include "qemu-common.h"
#include "qemu/bitops.h"
#include "exec/memory.h"
Expand Down
1 change: 0 additions & 1 deletion include/ui/console.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#include "qom/object.h"
#include "qapi/qmp/qdict.h"
#include "qemu/notify.h"
#include "qemu/typedefs.h"
#include "qapi-types.h"
#include "qemu/error-report.h"
#include "qapi/error.h"
Expand Down
3 changes: 0 additions & 3 deletions io/channel-websock.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@
#include "trace.h"
#include "qemu/iov.h"

#include <time.h>


/* Max amount to allow in rawinput/encoutput buffers */
#define QIO_CHANNEL_WEBSOCK_MAX_BUFFER 8192

Expand Down
1 change: 0 additions & 1 deletion linux-user/syscall.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
#include <sys/shm.h>
#include <sys/sem.h>
#include <sys/statfs.h>
#include <time.h>
#include <utime.h>
#include <sys/sysinfo.h>
#include <sys/signalfd.h>
Expand Down
2 changes: 0 additions & 2 deletions scsi/pr-helper.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@
#ifndef QEMU_PR_HELPER_H
#define QEMU_PR_HELPER_H 1

#include <stdint.h>

#define PR_HELPER_CDB_SIZE 16
#define PR_HELPER_SENSE_SIZE 96
#define PR_HELPER_DATA_SIZE 8192
Expand Down
1 change: 0 additions & 1 deletion target/i386/hvf/vmx.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
#ifndef VMX_H
#define VMX_H

#include <stdint.h>
#include <Hypervisor/hv.h>
#include <Hypervisor/hv_vmx.h>
#include "vmcs.h"
Expand Down
3 changes: 0 additions & 3 deletions target/i386/hvf/x86hvf.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,8 @@

#include "hw/i386/apic_internal.h"

#include <stdio.h>
#include <stdlib.h>
#include <Hypervisor/hv.h>
#include <Hypervisor/hv_vmx.h>
#include <stdint.h>

void hvf_set_segment(struct CPUState *cpu, struct vmx_segment *vmx_seg,
SegmentCache *qseg, bool is_tr)
Expand Down
1 change: 1 addition & 0 deletions target/xtensa/core-dc232b/xtensa-modules.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA
02110-1301, USA. */

#include "qemu/osdep.h"
#include "xtensa-isa.h"
#include "xtensa-isa-internal.h"

Expand Down
1 change: 1 addition & 0 deletions target/xtensa/core-dc233c/xtensa-modules.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */

#include "qemu/osdep.h"
#include "xtensa-isa.h"
#include "xtensa-isa-internal.h"

Expand Down
1 change: 1 addition & 0 deletions target/xtensa/core-de212/xtensa-modules.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */

#include "qemu/osdep.h"
#include "xtensa-isa.h"
#include "xtensa-isa-internal.h"

Expand Down
1 change: 1 addition & 0 deletions target/xtensa/core-fsf/xtensa-modules.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA
02110-1301, USA. */

#include "qemu/osdep.h"
#include "xtensa-isa.h"
#include "xtensa-isa-internal.h"

Expand Down
1 change: 1 addition & 0 deletions target/xtensa/core-sample_controller/xtensa-modules.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */

#include "qemu/osdep.h"
#include "xtensa-isa.h"
#include "xtensa-isa-internal.h"

Expand Down
4 changes: 1 addition & 3 deletions target/xtensa/xtensa-isa.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@
* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include "qemu/osdep.h"
#include "xtensa-isa.h"
#include "xtensa-isa-internal.h"

Expand Down
10 changes: 1 addition & 9 deletions tests/migration/stress.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,13 @@
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/

#include <stdio.h>
#include "qemu/osdep.h"
#include <getopt.h>
#include <string.h>
#include <stdlib.h>
#include <errno.h>
#include <unistd.h>
#include <sys/reboot.h>
#include <sys/syscall.h>
#include <linux/random.h>
#include <sys/time.h>
#include <pthread.h>
#include <fcntl.h>
#include <sys/mount.h>
#include <sys/stat.h>
#include <sys/mman.h>

const char *argv0;

Expand Down
2 changes: 1 addition & 1 deletion tests/ptimer-test.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
*
*/

#include "qemu/osdep.h"
#include <glib/gprintf.h>

#include "qemu/osdep.h"
#include "qemu/main-loop.h"
#include "hw/ptimer.h"

Expand Down
2 changes: 0 additions & 2 deletions trace/control-internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
#ifndef TRACE__CONTROL_INTERNAL_H
#define TRACE__CONTROL_INTERNAL_H

#include <stddef.h> /* size_t */

#include "qom/cpu.h"


Expand Down

0 comments on commit 8f0a371

Please sign in to comment.