refactor(editor): Remove old canvas code (no-changelog) (#13343)

n8n-io · Feb 19, 2025 · 143cb22 · 143cb22
1 parent 44121a9
commit 143cb22
Show file tree

Hide file tree

Showing 41 changed files with 84 additions and 11,941 deletions.
diff --git a/packages/@n8n/api-types/src/frontend-settings.ts b/packages/@n8n/api-types/src/frontend-settings.ts
@@ -1,4 +1,3 @@
-import type { FrontendBetaFeatures } from '@n8n/config';
 import type { ExpressionEvaluatorType, LogLevel, WorkflowSettings } from 'n8n-workflow';
 
 export interface IVersionNotificationSettings {
@@ -176,7 +175,6 @@ export interface FrontendSettings {
 	security: {
 		blockFileAccessToN8nFiles: boolean;
 	};
-	betaFeatures: FrontendBetaFeatures[];
 	easyAIWorkflowOnboarded: boolean;
 	partialExecution: {
 		version: 1 | 2;

diff --git a/packages/@n8n/config/src/configs/frontend.config.ts b/packages/@n8n/config/src/configs/frontend.config.ts
diff --git a/packages/@n8n/config/src/index.ts b/packages/@n8n/config/src/index.ts
@@ -31,7 +31,6 @@ export { Config, Env, Nested } from './decorators';
 export { TaskRunnersConfig } from './configs/runners.config';
 export { SecurityConfig } from './configs/security.config';
 export { ExecutionsConfig } from './configs/executions.config';
-export { FrontendBetaFeatures, FrontendConfig } from './configs/frontend.config';
 export { S3Config } from './configs/external-storage.config';
 export { LOG_SCOPES } from './configs/logging.config';
 export type { LogScope } from './configs/logging.config';

diff --git a/packages/cli/src/services/frontend.service.ts b/packages/cli/src/services/frontend.service.ts
@@ -1,5 +1,5 @@
 import type { FrontendSettings, ITelemetrySettings } from '@n8n/api-types';
-import { GlobalConfig, FrontendConfig, SecurityConfig } from '@n8n/config';
+import { GlobalConfig, SecurityConfig } from '@n8n/config';
 import { Container, Service } from '@n8n/di';
 import { createWriteStream } from 'fs';
 import { mkdir } from 'fs/promises';
@@ -44,7 +44,6 @@ export class FrontendService {
 		private readonly instanceSettings: InstanceSettings,
 		private readonly urlService: UrlService,
 		private readonly securityConfig: SecurityConfig,
-		private readonly frontendConfig: FrontendConfig,
 	) {
 		loadNodesAndCredentials.addPostProcessor(async () => await this.generateTypes());
 		void this.generateTypes();
@@ -232,7 +231,6 @@ export class FrontendService {
 			security: {
 				blockFileAccessToN8nFiles: this.securityConfig.blockFileAccessToN8nFiles,
 			},
-			betaFeatures: this.frontendConfig.betaFeatures,
 			easyAIWorkflowOnboarded: false,
 			partialExecution: this.globalConfig.partialExecutions,
 		};

diff --git a/packages/editor-ui/package.json b/packages/editor-ui/package.json
@@ -29,11 +29,6 @@
     "@codemirror/state": "^6.4.1",
     "@codemirror/view": "^6.26.3",
     "@fontsource/open-sans": "^4.5.0",
-    "@jsplumb/browser-ui": "^5.13.2",
-    "@jsplumb/common": "^5.13.2",
-    "@jsplumb/connector-bezier": "^5.13.2",
-    "@jsplumb/core": "^5.13.2",
-    "@jsplumb/util": "^5.13.2",
     "@lezer/common": "^1.0.4",
     "@n8n/api-types": "workspace:*",
     "@n8n/chat": "workspace:*",

diff --git a/packages/editor-ui/src/App.vue b/packages/editor-ui/src/App.vue
@@ -100,22 +100,22 @@ watch(defaultLocale, (newLocale) => {
 				<BannerStack v-if="!isDemoMode" />
 			</div>
 			<div id="header" :class="$style.header">
-				<router-view name="header"></router-view>
+				<RouterView name="header" />
 			</div>
 			<div v-if="usersStore.currentUser" id="sidebar" :class="$style.sidebar">
-				<router-view name="sidebar"></router-view>
+				<RouterView name="sidebar" />
 			</div>
 			<div id="content" :class="$style.content">
 				<div :class="$style.contentWrapper">
-					<router-view v-slot="{ Component }">
-						<keep-alive v-if="$route.meta.keepWorkflowAlive" include="NodeViewSwitcher" :max="1">
+					<RouterView v-slot="{ Component }">
+						<KeepAlive v-if="$route.meta.keepWorkflowAlive" include="NodeView" :max="1">
 							<component :is="Component" />
-						</keep-alive>
+						</KeepAlive>
 						<component :is="Component" v-else />
-					</router-view>
+					</RouterView>
 				</div>
 				<div v-if="hasContentFooter" :class="$style.contentFooter">
-					<router-view name="footer" />
+					<RouterView name="footer" />
 				</div>
 			</div>
 			<div :id="APP_MODALS_ELEMENT_ID" :class="$style.modals">

diff --git a/packages/editor-ui/src/Interface.ts b/packages/editor-ui/src/Interface.ts
@@ -1,6 +1,5 @@
 import type { Component } from 'vue';
 import type { NotificationOptions as ElementNotificationOptions } from 'element-plus';
-import type { Connection } from '@jsplumb/core';
 import type {
 	BannerName,
 	FrontendSettings,
@@ -1457,16 +1456,6 @@ export type ToggleNodeCreatorOptions = {
 export type AppliedThemeOption = 'light' | 'dark';
 export type ThemeOption = AppliedThemeOption | 'system';
 
-export type NewConnectionInfo = {
-	sourceId: string;
-	index: number;
-	eventSource: NodeCreatorOpenSource;
-	connection?: Connection;
-	nodeCreatorView?: NodeFilterType;
-	outputType?: NodeConnectionType;
-	endpointUuid?: string;
-};
-
 export type EnterpriseEditionFeatureKey =
 	| 'AdvancedExecutionFilters'
 	| 'Sharing'

diff --git a/packages/editor-ui/src/__tests__/defaults.ts b/packages/editor-ui/src/__tests__/defaults.ts
@@ -135,7 +135,6 @@ export const defaultSettings: FrontendSettings = {
 		enabled: false,
 		credits: 0,
 	},
-	betaFeatures: [],
 	easyAIWorkflowOnboarded: false,
 	partialExecution: {
 		version: 1,

diff --git a/packages/editor-ui/src/__tests__/mocks.ts b/packages/editor-ui/src/__tests__/mocks.ts
@@ -12,7 +12,7 @@ import type {
 	INodeIssues,
 } from 'n8n-workflow';
 import { NodeConnectionType, NodeHelpers, Workflow } from 'n8n-workflow';
-import { uuid } from '@jsplumb/util';
+import { v4 as uuid } from 'uuid';
 import { mock } from 'vitest-mock-extended';
 
 import {

diff --git a/packages/editor-ui/src/components/CanvasControls.vue b/packages/editor-ui/src/components/CanvasControls.vue