feat(editor): Add functionality to delete and rename folders (no-changelog) #13785
Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
MiloradFilipovic
force-pushed
the
ADO-3159-folders-p3-frontend
branch
from
92d10fa to
c6edbf1
Compare
| } | ||
|
|
||
| onMounted(async () => { | ||
| projectFolders.value = await foldersStore.fetchProjectFolders(route.params.projectId as string); |
There was a problem hiding this comment.
Why is it needed to load all project folders here, if the modal is deleting a single folder?
There was a problem hiding this comment.
This is used to populate dropdown if users want to move folder contents to different folder within the project:
There was a problem hiding this comment.
I guess this would be inefficient if there's too many folders. Ideally this would lazy load.
There was a problem hiding this comment.
Agree but do we have lazy loading feature in drop-downs? Alternatively, we can load them only if transfer is selected as an option here
There was a problem hiding this comment.
Element ui selects should already support this.
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ADO-3159-folders-p3-frontend
|
| Run status |
|
| Run duration | 04m 36s |
| Commit |
|
| Committer | Milorad Filipovic |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
6
|
Skipped
|
0
|
Passing
|
454
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Summary
Front-end part of Folders Phase 3 project. This PR introduces delete and rename functionality and add e2e tests for the features implemented so far.
Related Linear tickets, Github issues, and Community forum posts
Closes ADO-3158
Closes ADO-3159
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)