fix(core): Handle ghost nodes/connections gracefully #13840
+189
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
force-pushed
the
handle-phantom-nodes
branch
from
6556f5e to
1926752
Compare
n8n-assistant
bot
added
core
despairblue
reviewed
Mar 12, 2025
| for (const inputConnections of Object.values(returnConnection[sourceNode])) { | ||
| inputConnections.forEach((innerConnections, index) => { | ||
| if (innerConnections?.length) { | ||
| inputConnections[index] = innerConnections?.filter(({ node }) => node in this.nodes); |
There was a problem hiding this comment.
Suggested change
| inputConnections[index] = innerConnections?.filter(({ node }) => node in this.nodes); | |
| inputConnections[index] = innerConnections.filter(({ node }) => node in this.nodes); |
Already proved above.
Comment on lines
+280
to
+281
| const connectionsByDestinationNode = computed( | ||
| () => cachedWorkflow?.connectionsByDestinationNode ?? {}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a bug in the new canvas that doesn't delete all connections when a node is deleted.
This leads to the workflows on the backend that have ghost nodes, which leads to unexpected behavior.
This PR fixes the issue on the backend to handle such workflows that have already been saved to the DB.
We still need to create a fix for the frontend to cleanup connections properly when a node is deleted.
To reproduce the bug
on
masterthe execution should fail with an unhandled error, and on this branch, the execution should go through without any issues.Related Linear tickets, Github issues, and Community forum posts
Fixes #13086
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)