feat(Salesforce Node): Add support for PKCE #14082
Conversation
n8n-assistant
bot
added
n8n team
Joffcom
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
| displayName: 'Grant Type', | ||
| name: 'grantType', | ||
| type: 'hidden', | ||
| default: 'pkce', |
There was a problem hiding this comment.
@Joffcom wouldn't changing default break existing credentials? they had to be reconnected, right?
There was a problem hiding this comment.
@michael-radency I didn't have to reconnect my existing credential but you are right, it is possible that on refresh it errors out though. Let me see if I can think of a way to test that. Originally I was thinking about using a toggle option for PKCE but for some reason the grant type didn't like working with an expression.
There was a problem hiding this comment.
@michael-radency I connected my local env using non PKCE then used this branch and it has been running all weekend with no issues so I don't think this will break anything.
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
node-873-salesforce-add-pkce-support-to-the-credential
|
| Run status |
|
| Run duration | 04m 53s |
| Commit |
|
| Committer | Jonathan Bennetts |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
472
|
| View all changes introduced in this branch ↗︎ | |
|
Can you merge latest master and rerun e2e? Curious if that fixes the 49-folders issue Edit: It probably won't! Feel free to ignore the failed tests in 49-folders |
…ce-add-pkce-support-to-the-credential
|
✅ All Cypress E2E specs passed |
Joffcom
deleted the
node-873-salesforce-add-pkce-support-to-the-credential
branch
|
Got released with |
Summary
Enables PKCE support for Salesforce, Turns out if you don't have PKCE enabled in Salesforce it will still allow it to be used so the option they have is to enforce it.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-873/salesforce-add-pkce-support-to-the-credential
https://community.n8n.io/t/salesforce-credentials-bug-with-code-challenge/31845
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)