feat(API): Add the list of enabled modules in the frontend settings #14096
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumejacquart
changed the title
netroy
requested changes
Mar 21, 2025
| @@ -2,7 +2,7 @@ import { CommaSeperatedStringArray, Config, Env } from '@n8n/config'; | |||
| import { UnexpectedError } from 'n8n-workflow'; | |||
|
|
|||
| const moduleNames = ['insights'] as const; | |||
| type ModuleName = (typeof moduleNames)[number]; | |||
| export type ModuleName = (typeof moduleNames)[number]; | |||
There was a problem hiding this comment.
Perhaps we should move these types to @n8n/api-types as well. That way we don't need to duplicate the list of module names.
There was a problem hiding this comment.
@netroy I don't think it would be a good idea that @n8n/api-types contains the source of truth for the module list, what do you think ?
But I agree that the type could be extracted to the @n8n/api-types package. but since the type's value is to contain the list of possible module names, i'm not sure 🤔
n8n-assistant
bot
added
core
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide the frontend the list of all modules that have been enabled (for now only insights module), so that the front end can toggle the display of the insights overview
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2706/provide-list-of-enabled-modules-to-the-front
Review / Merge checklist
Docs updated or follow-up ticket created.PR Labeled withrelease/backport(if the PR is an urgent fix that needs to be backported)