fix: resolve Blade component class namespace issue by removing redundant 'app' prefix in the service provider and configuration. This caused components to not be recognized in Blade when variables were passed in the component's constructor. #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pp' prefix in PSR-4 configuration. This caused components to not be recognized in Blade when variables were passed in the component's constructor.
reza-asgharzadeh
changed the title
|
Nice work. Please keep the title short nice time. You can always add a description to explain what the PR does. |
solomon-ochepa
suggested changes
Feb 15, 2025
| @@ -116,7 +116,7 @@ | |||
| 'channels' => ['path' => 'app/Broadcasting', 'generate' => false], | |||
| 'class' => ['path' => 'app/Classes', 'generate' => false], | |||
| 'command' => ['path' => 'app/Console', 'generate' => false], | |||
| 'component-class' => ['path' => 'app/View/Components', 'generate' => false], | |||
| 'component-class' => ['path' => 'View/Components', 'generate' => false], | |||
There was a problem hiding this comment.
You are expected to change the value to whatever you wish in your published config file.
This default follows Laravel's standard structure and should remain unchanged.
| @@ -109,7 +109,7 @@ class $CLASS$ extends ServiceProvider | |||
|
|
|||
| $this->loadViewsFrom(array_merge($this->getPublishableViewPaths(), [$sourcePath]), $this->nameLower); | |||
|
|
|||
| $componentNamespace = $this->module_namespace($this->name, $this->app_path(config('modules.paths.generator.component-class.path'))); | |||
| $componentNamespace = $this->module_namespace($this->name, config('modules.paths.generator.component-class.path')); | |||
There was a problem hiding this comment.
You are expected to change the value to whatever you wish in your published config file.
The default follows Laravel's structure, but $this->app_path() does not enforce app/. You can leave it empty or set any value through the config.
|
This PR is a NO from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: resolve Blade component class namespace issue by removing redundant 'app' prefix in the service provider and configuration. This caused components to not be recognized in Blade when variables were passed in the component's constructor.
The issue was caused by the redundant 'app' prefix in the service provider and configuration, while the prefix is already defined in the PSR-4 configuration. As a result, the component class was not correctly linked to Blade, and variables defined in the component's constructor were not recognized. By removing the redundant 'app' prefix, the issue was resolved.