add test

nadar · Nov 14, 2020 · e0f6e96 · e0f6e96
1 parent 32024c8
commit e0f6e96
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/Job.php b/src/Job.php
@@ -95,6 +95,7 @@ public function run(RequestResponse $requestResponse, Crawler $crawler)
 
                 if ($parserResult->ignore) {
                     // for whatever reason the parser ignores this url
+                    unset($parserResult);
                     continue;
                 }
 

diff --git a/tests/CrawlerTest.php b/tests/CrawlerTest.php
@@ -23,6 +23,21 @@ public function testRunCrawler()
         $this->assertNotEmpty($debug->elapsedTime());
     }
 
+    public function testRunCrawlerWithGivenFilter()
+    {
+        $debug = new DebugHandler();
+
+        $crawler = new Crawler('https://luya.io', new ArrayStorage, new LoopRunner);
+        $crawler->urlFilterRules = [
+            '#/news#i'
+        ];
+        $crawler->addParser(new HtmlParser);
+        $crawler->addHandler($debug);
+        $this->assertEmpty($crawler->setup());
+        $this->assertEmpty($crawler->run());
+        $this->assertNotEmpty($debug->elapsedTime());
+    }
+
     public function testRunCrawlerButSkipResponseDueToVerySmallLimit()
     {
         $debug = new DebugHandler();