Fix issue #87 #88
Merged
Fix issue #87 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Could you please add a changelog entrie? otherwise i will do it for you. next patch version would be 3.4.2 |
Done! |
|
Thank you so much @shuedo! Perfect issue description, perfect error finding, perfect pull requesting with testings and changelog! If every pull request would be this way, the world would be a better place for sure! thanks 🌏 https://github.com/nadar/quill-delta-parser/releases/tag/3.4.2 |
|
Thanks, @nadar! Really appreciate the encouragement. I'm excited to keep contributing in the future! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue described in #87, where a line break preceding a list containing inline attributes results in improper HTML formatting.
this closes #87