Fix bugs related in non-integer ratios with thin #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulthebaker
changed the title
|
Hi @paulthebaker, it seems it's been a while since there has been active development here, aside from version updates and things. I saw some activity in #10 by @kdolum as well. Do you have progress on this PR? |
|
Changes included in #41 and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #20. Unfortunately, when
isave / thinis not an integersampler._writeToFileseems to write duplicate chain entries everyisave // thinsteps. I'm working on a fix to that, which is why this PR is a draftIn all cases
sampler._chainis correct. It's the periodic writing to file, which is pretty arcane in its implementation that is the problem.