Clean up some code warning #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moi Ran <[email protected]>
Signed-off-by: Moi Ran <[email protected]>
Signed-off-by: Moi Ran <[email protected]>
Signed-off-by: Moi Ran <[email protected]>
Signed-off-by: Moi Ran <[email protected]>
Signed-off-by: Moi Ran <[email protected]>
Signed-off-by: Moi Ran <[email protected]>
Signed-off-by: Moi Ran <[email protected]>
Signed-off-by: Moi Ran <[email protected]>
Signed-off-by: Moi Ran <[email protected]>
Signed-off-by: Moi Ran <[email protected]>
Signed-off-by: Moi Ran <[email protected]>
RanMaoyi
requested review from
StargazerWayne,
JaylinYu,
xinyi-xs and
wanghaEMQ
StargazerWayne
approved these changes
Jan 23, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
- Coverage 65.80% 65.75% -0.06%
==========================================
Files 129 129
Lines 37242 37238 -4
==========================================
- Hits 24508 24486 -22
- Misses 12734 12752 +18 ☔ View full report in Codecov by Sentry. |
RanMaoyi
force-pushed
the
moi/ringbuffer
branch
from
3dc1891 to
170c446
Compare
Signed-off-by: Moi Ran <[email protected]>
RanMaoyi
force-pushed
the
moi/ringbuffer
branch
from
170c446 to
5bead92
Compare
xinyi-xs
approved these changes
Jan 23, 2024
wanghaEMQ
reviewed
Jan 24, 2024
| @@ -447,7 +447,7 @@ extern int nni_plat_udp_sockname(nni_plat_udp *, nni_sockaddr *); | |||
| // in APIs to transport file descriptors, or across a fork/exec boundary (so | |||
| // that child processes may use these with socket to inherit a socket that is | |||
| // connected to the parent.) | |||
| extern int nni_socket_pair(int *); | |||
| extern int nni_socket_pair(int [2]); | |||
There was a problem hiding this comment.
whoops, this shall not be modified
There was a problem hiding this comment.
nng already fixed this in nanomsg/nng#1760
There was a problem hiding this comment.
then there shall be sth wrong on sync....
| @@ -179,7 +179,7 @@ nng_random(void) | |||
| } | |||
|
|
|||
| int | |||
| nng_socket_pair(int *fds) | |||
| nng_socket_pair(int fds[2]) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log_log side effects and some hard-to-clean code warnings have not been removed yet