Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use const for nng_stat when possible. #1895

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Use const for nng_stat when possible. #1895

merged 1 commit into from
Oct 21, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Oct 21, 2024

This should help the compiler enforce checks, and may result in better optimizations.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

This should help the compiler enforce checks, and may result
in better optimizations.
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.22%. Comparing base (5830408) to head (6937731).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/stats.c 57.89% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1895      +/-   ##
==========================================
+ Coverage   80.07%   80.22%   +0.14%     
==========================================
  Files          95       95              
  Lines       25010    25011       +1     
  Branches     3395     3395              
==========================================
+ Hits        20026    20064      +38     
+ Misses       4912     4874      -38     
- Partials       72       73       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 6937731 into main Oct 21, 2024
15 of 16 checks passed
@gdamore gdamore deleted the gdamore/stat/const branch December 28, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant