Aio begin cb #1983
Closed
Aio begin cb #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
==========================================
- Coverage 81.97% 81.90% -0.08%
==========================================
Files 95 95
Lines 24027 24034 +7
Branches 3165 3165
==========================================
- Hits 19696 19684 -12
- Misses 4260 4279 +19
Partials 71 71 ☔ View full report in Codecov by Sentry. |
gdamore
force-pushed
the
aio-begin-cb
branch
from
0f0cc86 to
3ee19a3
Compare
There is a very subtle case where an aio can be closed, but we don't realize it until precisely the moment of nni_aio_begin. This is eaten, and the submitter winds up having no way of knowing that the aio is closed, leading to a potential hang, or a leaked resource. It is very important that aio users check the return value and do not resubmit an operation once NNG_ECLOSED is returned. Otherwise a circular loop can result.
This is important to help differentiate between a single canceled operation and the situation where the entire underlying object is stopped and cannot be reused. Includes updates to docs and tests.
Also increase the backoff times to 1/2 seconds, if we are out of files or memory. If someone is up against this, they want to let the system calm down.
gdamore
force-pushed
the
aio-begin-cb
branch
from
3ee19a3 to
d50cf36
Compare
|
OBE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #
Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.