Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcp dialer tests: add local address tests #2037

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 31, 2024

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

@gdamore
Copy link
Contributor Author

gdamore commented Dec 31, 2024

Trying to increase coverage on this file.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.01%. Comparing base (071de8a) to head (5f7a9fe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/platform/posix/posix_tcpdial.c 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2037      +/-   ##
==========================================
+ Coverage   82.77%   83.01%   +0.24%     
==========================================
  Files          95       95              
  Lines       23771    23766       -5     
  Branches     3068     3067       -1     
==========================================
+ Hits        19677    19730      +53     
+ Misses       4017     3957      -60     
- Partials       77       79       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore force-pushed the tcp-dialer-local-test branch from 207a6d1 to c30939a Compare December 31, 2024 06:29
@gdamore gdamore force-pushed the tcp-dialer-local-test branch from 2276f69 to 5f7a9fe Compare December 31, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant