Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

args: Convert nng_opts_parse into a header only library using `nng_ar… #2069

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Jan 5, 2025

…gs_parse`.

The API is identical, except that some names have changed, and this is now a header library in nng/args.h - so the core library does not need to carry this code in binaries. Being a header library also means it is not necessary to link against NNG, and it does not include any parts of NNG; it only depends on a standard C99 or C11 environment.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

…gs_parse`.

The API is identical, except that some names have changed, and this is now a
header library in `nng/args.h` - so the core library does not need to carry this
code in binaries.  Being a header library also means it is not necessary to
link against NNG, and it does not include any parts of NNG; it only depends on
a standard C99 or C11 environment.
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.07%. Comparing base (a40b421) to head (f77e5a5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/tools/nngcat/nngcat.c 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2069      +/-   ##
==========================================
+ Coverage   82.94%   83.07%   +0.12%     
==========================================
  Files          94       94              
  Lines       23719    23717       -2     
  Branches     3064     3059       -5     
==========================================
+ Hits        19673    19702      +29     
+ Misses       3970     3934      -36     
- Partials       76       81       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit f77e5a5 into main Jan 5, 2025
37 checks passed
@gdamore gdamore deleted the args-parse branch January 5, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant