HTTP API refactoring #2075
Open
HTTP API refactoring #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function required the request and response to be preallocated separately, which is a little awkward. Instead, we have the nng_http_conn_transact function. This function does require a connection to be established first, but then it is easier to manage. This is part of overall goal of removing separate allocation and removal of request and reply objects.
Starting to use methods to access the connection directly, and using res inline. Also inlined the aio on the HTTP transaction.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2075 +/- ##
==========================================
+ Coverage 82.91% 83.04% +0.12%
==========================================
Files 94 94
Lines 23694 23697 +3
Branches 3052 3055 +3
==========================================
+ Hits 19646 19678 +32
+ Misses 3967 3939 -28
+ Partials 81 80 -1 ☔ View full report in Codecov by Sentry. |
A few standard headers like content-length can always be provided in the connection object, avoiding the need for strdup or allocations for the header block. This eliminates up to 3 allocs for each header.
Try harder to avoid some allocations, use Host separately and inherit from the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress -- refactoring the HTTP API entirely.