Convert from CJS to ESM

The server builds are still CJS for now. This is made possible by
remix-run/remix#7180, which was included in
the recent release of Remix 2.0.1.

__mocks__/openid-client.js

@@ -2,4 +2,4 @@ const openid_client = jest.createMockFromModule('openid-client')
 
 openid_client.TokenSet = {}
 
-module.exports = openid_client
+export default openid_client

app/email-incoming/circulars/index.ts

@@ -47,9 +47,7 @@ interface EmailProps {
 
 const fromName = 'GCN Circulars'
 
-// FIXME: must use module.exports here for OpenTelemetry shim to work correctly.
-// See https://dev.to/heymarkkop/how-to-solve-cannot-redefine-property-handler-on-aws-lambda-3j67
-module.exports.handler = createEmailIncomingMessageHandler(
+export const handler = createEmailIncomingMessageHandler(
   async ({ content }) => {
     const parsed = await parseEmailContentFromSource(content)
     const { address: userEmail, submittedHow } = getFromAddress(parsed.from)

app/email-incoming/support/index.ts

@@ -33,11 +33,8 @@ const origData = {
 
 /**
  * Forward incoming emails to Zendesk.
- *
- * FIXME: must use module.exports here for OpenTelemetry shim to work correctly.
- * See https://dev.to/heymarkkop/how-to-solve-cannot-redefine-property-handler-on-aws-lambda-3j67
  */
-module.exports.handler = createEmailIncomingMessageHandler(
+export const handler = createEmailIncomingMessageHandler(
   async ({ content, receipt: { recipients } }) => {
     let data = { recipients, emailData: content.toString(), ...origData }
     data = await transformRecipients(data)

app/scheduled/ads/index.ts

@@ -40,9 +40,7 @@ async function* getAdsEntries() {
   } while (length)
 }
 
-// FIXME: must use module.exports here for OpenTelemetry shim to work correctly.
-// See https://dev.to/heymarkkop/how-to-solve-cannot-redefine-property-handler-on-aws-lambda-3j67
-module.exports.handler = async () => {
+export async function handler() {
   const db = await tables()
   for await (const entries of getAdsEntries()) {
     await Promise.all(

app/scheduled/circulars/index.ts

@@ -9,8 +9,6 @@ import { forAllCirculars } from './actions'
 import { statsAction } from './actions/stats'
 import { jsonUploadAction, txtUploadAction } from './actions/tar'
 
-// FIXME: must use module.exports here for OpenTelemetry shim to work correctly.
-// See https://dev.to/heymarkkop/how-to-solve-cannot-redefine-property-handler-on-aws-lambda-3j67
-module.exports.handler = async () => {
+export async function handler() {
   await forAllCirculars(jsonUploadAction, txtUploadAction, statsAction)
 }

app/table-streams/circulars/index.ts

@@ -109,9 +109,7 @@ async function send(circular: Circular) {
   })
 }
 
-// FIXME: must use module.exports here for OpenTelemetry shim to work correctly.
-// See https://dev.to/heymarkkop/how-to-solve-cannot-redefine-property-handler-on-aws-lambda-3j67
-module.exports.handler = createTriggerHandler(
+export const handler = createTriggerHandler(
   async ({ eventName, dynamodb }: DynamoDBRecord) => {
     const id = unmarshallTrigger(dynamodb!.Keys).circularId as number
     const promises = []

esbuild.mjs → esbuild.js

@@ -16,6 +16,7 @@ const options = {
   logLevel: 'info',
   outdir: 'build',
   outbase: 'app',
+  outExtension: { '.js': '.cjs' },
   external: ['@aws-sdk/*', 'aws-sdk'],
   platform: 'node',
   target: ['node18'],

package.json

@@ -1,5 +1,6 @@
 {
   "private": true,
+  "type": "module",
   "name": "@nasa-gcn/gcn.nasa.gov",
   "description": "General Coordinates Network web site",
   "repository": {
@@ -10,12 +11,12 @@
   "scripts": {
     "build:remix": "remix build",
     "build:sass": "sass -Inode_modules/nasawds/src/theme -Inode_modules/@uswds -Inode_modules/@uswds/uswds/packages app:app",
-    "build:esbuild": "node esbuild.mjs",
+    "build:esbuild": "node esbuild.js",
     "build:website": "run-s build:sass build:remix",
     "build": "run-p build:website build:esbuild",
     "dev:remix": "remix dev --manual -c \"arc sandbox -e testing --host localhost\"",
     "dev:sass": "sass --watch -Inode_modules/nasawds/src/theme -Inode_modules/@uswds -Inode_modules/@uswds/uswds/packages app:app",
-    "dev:esbuild": "node esbuild.mjs --dev",
+    "dev:esbuild": "node esbuild.js --dev",
     "dev": "run-p \"dev:*\"",
     "prepare": "husky install",
     "deploy": "arc deploy --no-hydrate --prune --production",

remix.config.mjs → remix.config.js

@@ -61,7 +61,7 @@ export default {
   assetsBuildDirectory: 'build/static',
   publicPath: '/_static/app/',
   server: './server.ts',
-  serverBuildPath: 'build/server/index.js',
+  serverBuildPath: 'build/server/index.cjs',
   serverMinify: isProduction,
   serverModuleFormat: 'cjs',
   serverDependenciesToBundle: [

sandbox-search.js

@@ -5,10 +5,9 @@
  *
  * SPDX-License-Identifier: Apache-2.0
  */
+import { readFile } from 'fs/promises'
 
-const { readFile } = require('fs/promises')
-
-module.exports = async function () {
+export default async function () {
   const text = await readFile('sandbox-seed.json', { encoding: 'utf-8' })
   const { circulars } = JSON.parse(text)
   return circulars.flatMap((item) => [

server.ts

@@ -6,9 +6,7 @@ import sourceMapSupport from 'source-map-support'
 sourceMapSupport.install()
 installGlobals()
 
-// FIXME: must use module.exports here for OpenTelemetry shim to work correctly.
-// See https://dev.to/heymarkkop/how-to-solve-cannot-redefine-property-handler-on-aws-lambda-3j67
-module.exports.handler = createRequestHandler({
+export const handler = createRequestHandler({
   build,
   mode: process.env.NODE_ENV,
 })

src/plugins/plugin-remix.mjs → src/plugins/plugin-remix.js

@@ -5,7 +5,7 @@ import { logDevReady } from '@remix-run/node'
 import * as fs from 'node:fs'
 import * as path from 'node:path'
 
-const buildPath = 'build/server/index.js'
+const buildPath = 'build/server/index.cjs'
 
 let lastTimeout