Add Parse JSON Notices Section #2669
Closed
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vidushi-GitHub
requested review from
lpsinger,
jracusin,
dakota002 and
tylerbarna
Closed
Vidushi-GitHub
assigned Vidushi-GitHub and tylerbarna and unassigned tylerbarna and Vidushi-GitHub
lpsinger
requested changes
Nov 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2669 +/- ##
========================================
- Coverage 6.06% 5.93% -0.14%
========================================
Files 171 171
Lines 4334 4329 -5
Branches 476 474 -2
========================================
- Hits 263 257 -6
- Misses 4069 4070 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
lpsinger
requested changes
Nov 8, 2024
|
This encoding information needs to also be referenced somewhere in the creating JSON notices documentation. |
|
Add example of pulling message off the network and getting bytes out. |
Vidushi-GitHub
commented
Dec 2, 2024
Vidushi-GitHub
commented
Dec 6, 2024
lpsinger
requested changes
Dec 6, 2024
Vidushi-GitHub
force-pushed
the
ParseJSON
branch
from
261b6ab to
3f09546
Compare
Vidushi-GitHub
commented
Dec 19, 2024
lpsinger
requested changes
Dec 19, 2024
Vidushi-GitHub
force-pushed
the
ParseJSON
branch
from
c2e6704 to
e9225b0
Compare
|
@dakota002 please provide your suggestions. |
dakota002
reviewed
Jan 17, 2025
jracusin
reviewed
Jan 17, 2025
lpsinger
requested changes
Jan 17, 2025
app/routes/docs.client.samples.md
Outdated
Comment on lines
218
to
229
| # Function to validate Base64 strings | ||
| def is_base64(s): | ||
| try: | ||
| base64.b64decode(s, validate=True) | ||
| return True | ||
| except Exception: | ||
| return False | ||
|
|
||
| # Output: A Base64 encoded bytestring, e.g., b'a1512dabc1b6adb3cd1b6dcb6d4c6......' | ||
| with open("path/to/encoded_file.txt", 'wb') as encoded_file: | ||
| encoded_file.write(encoded_string) | ||
| # Validate the skymap string | ||
| if not is_base64(skymap_string): | ||
| print("Invalid Base64 string.") | ||
| continue |
There was a problem hiding this comment.
We can remove it, it's just a check if file wasn't corrupted.
jracusin
reviewed
Jan 17, 2025
jracusin
reviewed
Jan 17, 2025
jracusin
reviewed
Jan 17, 2025
app/routes/docs.client.samples.md
Outdated
| import base64 | ||
|
|
||
| # Set Kafka Topic and Producer Configuration | ||
| TOPIC = "gcn.circulars" |
There was a problem hiding this comment.
This doesn't seem like the right topic.
jracusin
reviewed
Jan 17, 2025
Vidushi-GitHub
commented
Jan 17, 2025
Vidushi-GitHub
commented
Jan 17, 2025
lpsinger
requested changes
Feb 3, 2025
app/routes/docs.client.samples.md
Outdated
| # Connect as a Kafka consumer | ||
| consumer = Consumer(client_id='fill me in', # Replace with your client ID | ||
| client_secret='fill me in', # Replace with your client secret | ||
| config={"message.max.bytes": 204194304}, |
app/routes/docs.client.samples.md
Outdated
|
|
||
| producer = Producer(client_id='fill me in', # Replace with your client ID | ||
| client_secret='fill me in', # Replace with your client secret | ||
| config={"message.max.bytes": 204194304}, |
Vidushi-GitHub
commented
Feb 3, 2025
|
Note that there are merge conflicts. Please fix them. |
Vidushi-GitHub
force-pushed
the
ParseJSON
branch
from
ffb57c3 to
d6f64a8
Compare
I was rebasing for merge conflicts, looks it got closed :( |
|
Still working on this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document includes how to parse, encode, decode the JSON Schema files.
Resolves: #2149
Previous branch (#2506) had 100+ commits behind, rebase was messy and touched many files.
Feedbacks need to be included:
-Provide hyperlinks to these Python methods.
-Please provide sample code for parsing Kafka records in a message consuming loop