Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVOM Missionpage #2856

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vidushi-GitHub
Copy link
Member

@Vidushi-GitHub Vidushi-GitHub commented Jan 24, 2025

Description

This pull request (PR) introduces the SVOM mission page on the GCN website.

Feedback from the SVOM team (Vidushi-GitHub#7) has been implemented
and the .svg logo is attached.

Related Issue(s)

Closing #2637, an old branch, and have issues with clean rebase w/t touching files.

@timroland Please review!
We have a question regarding the HEASARC link: Is SVOM planning to archive data on HEASARC,
as it contains generic information of mission right now?

Screenshot attached:
Screenshot 2025-01-24 at 3 58 50 PM
Screenshot 2025-01-24 at 3 59 12 PM

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.93%. Comparing base (0242bde) to head (783e75d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2856   +/-   ##
=====================================
  Coverage   5.93%   5.93%           
=====================================
  Files        171     171           
  Lines       4329    4329           
  Branches     474     474           
=====================================
  Hits         257     257           
  Misses      4070    4070           
  Partials       2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timroland
Copy link

timroland commented Jan 27, 2025

Hi,

thanks for your rapid answer @Vidushi-GitHub ! There are some typo, I think I made the merge a bit too fast. I need to change some things.
To answer on the archive, we do not have any public archive ready for the moment. I think it will be linked to the heasarc page in the future, but for the moment the heasarc link is useless.

@Kaustavpal007

This comment was marked as spam.

@timroland timroland mentioned this pull request Jan 28, 2025
**End of Operations:** Mission duration of 3 years

**Data Archive:**
[HEASARC SVOM Archive](https://heasarc.gsfc.nasa.gov/docs/heasarc/missions/svom.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this isn't or will not be a data archive, we should remove this section.


</div>

#### JSON-Serialized GCN Notice Types in GCN Kafka
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not list this as JSON, instead make it clear that it's VOEvent XML-serialized GCN Notices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants