Courey/circular view toggle #2919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accidentally added local development work forgot seed file renaming reverting package json
Courey
commented
Feb 25, 2025
| </details> | ||
| </div> | ||
| ))} | ||
| <div className="margin-top-2"> |
There was a problem hiding this comment.
this is just adding the same amount of padding that is on the index results so the results don't have a different gap based on the different view.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2919 +/- ##
========================================
- Coverage 5.97% 5.96% -0.02%
========================================
Files 171 174 +3
Lines 4334 4344 +10
Branches 476 477 +1
========================================
Hits 259 259
- Misses 4073 4083 +10
Partials 2 2 ☔ View full report in Codecov by Sentry. |
jracusin
reviewed
Feb 25, 2025
| @@ -268,7 +281,7 @@ export default function () { | |||
| name="query" | |||
| type="search" | |||
| defaultValue={inputQuery} | |||
| placeholder="Search" | |||
| placeholder={searchText} | |||
There was a problem hiding this comment.
This is also implemented in #2837, with slightly different wording.
There was a problem hiding this comment.
which one would we like to go with? Would you like me to remove the placeholder in this branch?
lpsinger
requested changes
Feb 25, 2025
|
lpsinger
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turns the view selection into a toggle and brings all button order and size into line so there is no jumping around.
Related Issue(s)
Resolves #2866
Testing
This was tested locally visually with the flag on and off
FLAG ON:
FLAG OFF: