Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Tab hover border not overlap blue area #1301

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Make Tab hover border not overlap blue area #1301

merged 1 commit into from
Sep 17, 2018

Conversation

Benjaki2
Copy link
Collaborator

@Benjaki2 Benjaki2 commented Sep 17, 2018 •
edited
Loading

Description

Fixes #1278 .

  • Make it so white tab border does not cover blue bottom-border on hover

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been merged and published in downstream modules (if applicable)

@nasa-gibs/worldview

@Benjaki2 Benjaki2 added this to the September Release milestone Sep 17, 2018
@Benjaki2 Benjaki2 self-assigned this Sep 17, 2018
@Benjaki2 Benjaki2 requested a review from edplato September 17, 2018 01:42
@ghost ghost added the under development label Sep 17, 2018
edplato
edplato approved these changes Sep 17, 2018
View reviewed changes
Copy link
Collaborator

@edplato edplato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and clean!

@Benjaki2 Benjaki2 merged commit 220f708 into develop Sep 17, 2018
@Benjaki2 Benjaki2 deleted the fix-tab-border-1278 branch September 17, 2018 15:12
@ghost ghost removed the under development label Sep 17, 2018
@ZachTRice ZachTRice mentioned this pull request Sep 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edplato edplato edplato approved these changes

Assignees

@Benjaki2 Benjaki2

Labels
None yet
Projects
None yet
Milestone
September Release (v2.9.0)
Development

Successfully merging this pull request may close these issues.
2 participants
@Benjaki2 @edplato