Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS Noetic Java Generator #770

Merged
merged 10 commits into from
Mar 22, 2024
Merged

Conversation

rgarciaruiz
Copy link
Contributor

@rgarciaruiz rgarciaruiz commented Mar 6, 2024

Debians created from these scripts contain a minimal set of patches that enable generation of Java messages on ROS Noetic.

@trey0
Copy link
Contributor

trey0 commented Mar 6, 2024

Hi, Ruben- I'm excited to see your progress with this! I added a suggested edit to the system requirements section of the install instructions, assuming I understand what you're trying to do here.

Some other suggestions for useful additions if you have the time:

  • Updated documentation about the new way to build the JAR file. (I don't know which repo that goes in or if there is any old README that can be edited, vs. we have to create instructions from scratch.)
  • Possibly a new CI action for GitHub that successfully builds the JAR file. That's always good for peace of mind.

Thanks!

@rgarciaruiz
Copy link
Contributor Author

Thank you for the doc update!

As for the remaining of the documentation, you can take a look at this PR. Let me know if you have any comments.

As for the CI action, good idea. I may just repurpose the build_msgs_jar.Dockerfile for that.

@rgarciaruiz rgarciaruiz marked this pull request as ready for review March 13, 2024 22:09
Copy link
Contributor

@trey0 trey0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

scripts/docker/build_msgs_jar.Dockerfile Outdated Show resolved Hide resolved
@rgarciaruiz rgarciaruiz merged commit 11eab6f into nasa:develop Mar 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants