Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update development dependencies to mitigate Snyk-reported vulnerabilities #42

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Update development dependencies to mitigate Snyk-reported vulnerabilities #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7de043d
Update development dependencies to mitigate Snyk-reported vulnerabili…
owenlittlejohns Nov 3, 2023
2656cd4
Explicitly pin werkzeug.
owenlittlejohns Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions requirements/dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
autopep8 ~= 2.0.1
coverage ~= 7.1.0
flake8 ~= 6.0
ipython ~= 7.32
isort ~= 5.5
moto ~= 1.3
pytest ~= 7.2.1
python-dotenv ~=0.21
safety ~= 1.10
autopep8 ~= 2.0.4
coverage ~= 7.3.2
flake8 ~= 6.1.0
ipython ~= 8.17.2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was also a medium severity vulnerability in ipython. That should now be squashed.

There was one last medium severity vulnerability in setuptools, but when I ran things locally, the new versions of everything didn't look like they included setuptools, so that should also be squashed.

isort ~= 5.12.0
moto ~= 4.2.7
pytest ~= 7.4.3
python-dotenv ~=1.0.0
safety ~= 2.3.5
werkzeug ~= 3.0.1 # Dependency of moto, pinned to mitigate vulnerability.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running the installation on my local machine (in a Python 3.9 environment), moto~=4.2.7 led to werkzeug==3.0.1, which mitigates the issue. However, Snyk still pulled in an older version of werkzeug when running the scan. I suspect it relates to Snyk running the scan under Python 3.7.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't great, but I'm following along with the slack chat to see if we can resolve it differently for the future.