Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added discrete states (Closes #117) #178

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Dec 11, 2024

Closes #177

Adds the option of discrete states to ProgPy. Discrete states are implemented by initializing a state using the Discrete State Object. Created a TankModel to represent this.

This required some extra logic to support, especially changing the way containers work

I also added a jupyter notebook to demonstrate this feature. This notebook will later be merged into the numbered notebooks

Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant