Pinning sqlite for binary builds #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phargogh
requested changes
Feb 28, 2025
There was a problem hiding this comment.
sqlite is interesting because it is a conda-forge package, but it is not a package on PyPI. Anything we put into requirements.txt MUST be a PyPI-installable dependency.
Instead, I think this addition should go in our requirements-to-conda-forge conversion script at https://github.com/natcap/invest/blob/main/scripts/convert-requirements-to-conda-yml.py
|
Sorry to jump in, but wasn't this done in #1799? |
|
Ha, thanks for jumping in @emlys . I completely missed this and it explains why the binary build wasn't catching it. |
phargogh
approved these changes
Feb 28, 2025
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #1799. It looks like the dependency wasn't being handled in the binary build environment that is set up. This PR moves the restriction to the top conda dependency environment variable, to avoid missing it in the subsequent set ups. Even though it's not necessary for each environment being set up. Happy to chat about this and whether this is something that would be better maintained in
scripts/convert-requirements-to-conda-yml.pyor elsewhere.Checklist